Re: [PATCH V2] mm: hugetlb: Introduce huge_pte_{page,present,young}

[Gerald Schaefer <gerald.schaefer@de.ibm.com>]

On Thu, 27 Mar 2014 15:11:30 +0000
Steve Capper <steve.capper@linaro.org> wrote:

> On Thu, Mar 20, 2014 at 01:17:53PM +0000, Steve Capper wrote:
> > Introduce huge pte versions of pte_page, pte_present and pte_young.
> > 
> > This allows ARM (without LPAE) to use alternative pte processing logic
> > for huge ptes.
> > 
> > Generic implementations that call the standard pte versions are also
> > added to asm-generic/hugetlb.h.
> > 
> > Signed-off-by: Steve Capper <steve.capper@linaro.org>
> > ---
> > Changed in V2 - moved from #ifndef,#define macros to entries in
> > asm-generic/hugetlb.h as it makes more sense to have these with the
> > other huge_pte_. definitions.
> > 
> > The only other architecture I can see that does not use
> > asm-generic/hugetlb.h is s390. This patch includes trivial definitions
> > for huge_pte_{page,present,young} for s390.
> > 
> > I've compile-tested this for s390, but don't have one under my desk so
> > have not been able to test it.
> > ---
> >  arch/s390/include/asm/hugetlb.h | 15 +++++++++++++++
> >  include/asm-generic/hugetlb.h   | 15 +++++++++++++++
> >  mm/hugetlb.c                    | 22 +++++++++++-----------
> >  3 files changed, 41 insertions(+), 11 deletions(-)
> > 
> 
> Hello,
> I was just wondering if this patch looked reasonable to people?

Looks good, and I also tested it on s390, so for the s390 part:
Acked-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>