From: Christoph Hellwig <hch@infradead.org>
To: Richard Hansen <rhansen@bbn.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, Greg Troxel <gdt@ir.bbn.com>
Subject: Re: [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC
Date: Wed, 2 Apr 2014 04:10:32 -0700 [thread overview]
Message-ID: <20140402111032.GA27551@infradead.org> (raw)
In-Reply-To: <533B04A9.6090405@bbn.com>
On Tue, Apr 01, 2014 at 02:25:45PM -0400, Richard Hansen wrote:
> For the flags parameter, POSIX says "Either MS_ASYNC or MS_SYNC shall
> be specified, but not both." [1] There was already a test for the
> "both" condition. Add a test to ensure that the caller specified one
> of the flags; fail with EINVAL if neither are specified.
This breaks various (sloppy) existing userspace for no gain.
NAK.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-02 11:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 18:25 [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC Richard Hansen
2014-04-01 19:32 ` Michael Kerrisk (man-pages)
2014-04-02 0:53 ` Richard Hansen
2014-04-02 10:45 ` chrubis
2014-04-02 11:10 ` Christoph Hellwig [this message]
2014-04-02 11:45 ` Steven Whitehouse
2014-04-02 23:44 ` Richard Hansen
2014-04-03 8:25 ` Michael Kerrisk (man-pages)
2014-04-03 11:51 ` Christopher Covington
2014-04-04 6:54 ` Michael Kerrisk (man-pages)
2014-04-03 12:57 ` Greg Troxel
2014-04-04 7:11 ` Michael Kerrisk (man-pages)
2014-04-03 20:23 ` Richard Hansen
2014-04-04 6:53 ` Christoph Hellwig
2014-04-04 7:12 ` [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC [resend] Michael Kerrisk (man-pages)
2014-04-04 14:07 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2013-09-01 19:58 [PATCH] mm: msync: require either MS_ASYNC or MS_SYNC Richard Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402111032.GA27551@infradead.org \
--to=hch@infradead.org \
--cc=gdt@ir.bbn.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rhansen@bbn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).