linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Hugh Dickins <hughd@google.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Mel Gorman <mgorman@suse.de>,
	Dave Jones <davej@redhat.com>, linux-mm <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: mm: BUG in do_huge_pmd_wp_page
Date: Mon, 7 Apr 2014 23:11:06 +0300	[thread overview]
Message-ID: <20140407201106.GA21633@node.dhcp.inet.fi> (raw)
In-Reply-To: <5342FF3E.6030306@oracle.com>

On Mon, Apr 07, 2014 at 03:40:46PM -0400, Sasha Levin wrote:
> It also breaks fairly quickly under testing because:
> 
> On 04/07/2014 10:48 AM, Kirill A. Shutemov wrote:
> > +	if (IS_ENABLED(CONFIG_DEBUG_PAGEALLOC)) {
> > +		spin_lock(ptl);
> 
> ^ We go into atomic
> 
> > +		if (unlikely(!pmd_same(*pmd, orig_pmd)))
> > +			goto out_race;
> > +	}
> > +
> >  	if (!page)
> >  		clear_huge_page(new_page, haddr, HPAGE_PMD_NR);
> >  	else
> >  		copy_user_huge_page(new_page, page, haddr, vma, HPAGE_PMD_NR);
> 
> copy_user_huge_page() doesn't like running in atomic state,
> and asserts might_sleep().

Okay, I'll try something else.

-- 
 Kirill A. Shutemov

  reply	other threads:[~2014-04-07 20:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 13:04 mm: BUG in do_huge_pmd_wp_page Sasha Levin
2013-04-04 14:03 ` Sasha Levin
2013-04-04 14:30   ` Kirill A. Shutemov
2013-04-04 14:37     ` Sasha Levin
2013-04-04 16:28       ` Kirill A. Shutemov
2013-04-04 21:54         ` Sasha Levin
2014-04-04 19:37   ` Sasha Levin
2014-04-07 14:48     ` Kirill A. Shutemov
2014-04-07 14:56       ` Sasha Levin
2014-04-07 19:40       ` Sasha Levin
2014-04-07 20:11         ` Kirill A. Shutemov [this message]
2014-05-15 17:31           ` Sasha Levin
2014-05-15 17:37             ` Hugh Dickins
2014-05-15 17:43               ` Sasha Levin
2014-05-15 17:58                 ` Hugh Dickins
2013-04-10  8:02 ` Minchan Kim
2013-04-11 13:18   ` Kirill A. Shutemov
2013-04-14  7:13     ` Minchan Kim
2013-04-11 14:55   ` Sasha Levin
2013-04-11 15:13     ` Kirill A. Shutemov
2013-04-11 15:14       ` Sasha Levin
2013-04-24 22:46         ` Andrew Morton
2013-04-26  0:51           ` Sasha Levin
2013-04-26  2:01             ` Dave Jones
2013-04-26  3:12               ` Sasha Levin
2014-02-04  3:01               ` Sasha Levin
2014-02-04  3:59                 ` Hugh Dickins
2014-02-04 16:58                   ` Kirill A. Shutemov
2014-02-05 18:12                   ` Sasha Levin
2014-02-05 22:50                     ` Hugh Dickins
2013-04-24 22:51   ` H. Peter Anvin
2013-04-24 23:40     ` Simon Jeons
2013-04-26  2:28       ` H. Peter Anvin
2013-04-26  1:30     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140407201106.GA21633@node.dhcp.inet.fi \
    --to=kirill@shutemov.name \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rientjes@google.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).