From: Mel Gorman <mgorman@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Linux-X86 <x86@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Steven Noonan <steven@uplinklabs.net>,
Rik van Riel <riel@redhat.com>,
David Vrabel <david.vrabel@citrix.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2
Date: Tue, 8 Apr 2014 18:03:11 +0100 [thread overview]
Message-ID: <20140408170310.GO7292@suse.de> (raw)
In-Reply-To: <20140408164652.GL7292@suse.de>
On Tue, Apr 08, 2014 at 05:46:52PM +0100, Mel Gorman wrote:
> On Tue, Apr 08, 2014 at 08:22:15AM -0700, Linus Torvalds wrote:
> > On Tue, Apr 8, 2014 at 7:40 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> > >
> > > David, is your patchset going to be pushed in this merge window as expected?
> >
> > Apparently aiming for 3.16 right now.
> >
>
> > > That being said, these bits are precious, and if this ends up being a
> > > case where "only Xen needs another bit" once again then Xen should
> > > expect to get kicked to the curb at a moment's notice.
> >
> > Quite frankly, I don't think it's a Xen-only issue. The code was hard
> > to figure out even without the Xen issues. For example, nobody ever
> > explained to me why it
> >
> > (a) could be the same as PROTNONE on x86
> > (b) could not be the same as PROTNONE in general
>
> This series exists in response to your comment
>
> I fundamentally think that it was a horrible horrible disaster to
> make _PAGE_NUMA alias onto _PAGE_PROTNONE.
>
> As long as _PAGE_NUMA aliases to _PAGE_PROTNONE on x86 then the core has to
> play games to take that into account and the code will be "hard to figure
> out even without the Xen issues".
Is what you want for _PAGE_NUMA to disappear from arch/x86 and instead
use _PAGE_PROTNONE with comments explaining why and leave the core as it
is?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-08 17:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:09 [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2 Mel Gorman
2014-04-08 13:09 ` [PATCH 1/5] x86: Require x86-64 for automatic NUMA balancing Mel Gorman
2014-04-08 13:09 ` [PATCH 2/5] x86: Define _PAGE_NUMA by reusing software bits on the PMD and PTE levels Mel Gorman
2014-04-08 13:09 ` [PATCH 3/5] mm: Allow FOLL_NUMA on FOLL_FORCE Mel Gorman
2014-04-08 13:09 ` [PATCH 4/5] mm: use paravirt friendly ops for NUMA hinting ptes Mel Gorman
2014-04-08 17:21 ` David Vrabel
2014-04-15 10:27 ` David Vrabel
2014-04-15 14:44 ` Mel Gorman
2014-04-08 13:09 ` [PATCH 5/5] x86: Allow Xen to enable NUMA_BALANCING Mel Gorman
2014-04-08 14:40 ` [RFC PATCH 0/5] Use an alternative to _PAGE_PROTNONE for _PAGE_NUMA v2 H. Peter Anvin
2014-04-08 15:22 ` Linus Torvalds
2014-04-08 16:04 ` H. Peter Anvin
2014-04-08 16:12 ` Peter Zijlstra
2014-04-08 16:46 ` Mel Gorman
2014-04-08 17:01 ` Linus Torvalds
2014-04-08 18:51 ` Mel Gorman
2014-04-08 18:55 ` Linus Torvalds
2014-04-08 19:06 ` Mel Gorman
2014-04-08 19:08 ` Rik van Riel
2014-04-08 17:03 ` Mel Gorman [this message]
2014-04-08 17:30 ` Peter Zijlstra
2014-04-08 17:41 ` Linus Torvalds
2014-04-08 18:16 ` Cyrill Gorcunov
2014-04-09 6:21 ` Ingo Molnar
2014-04-09 23:34 ` H. Peter Anvin
2014-04-10 0:12 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408170310.GO7292@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=david.vrabel@citrix.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=steven@uplinklabs.net \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).