From: Andrew Morton <akpm@linux-foundation.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
hughd@google.com, xemul@parallels.com
Subject: Re: [patch 2/4] mm: Dont forget to set softdirty on file mapped fault
Date: Mon, 14 Apr 2014 15:27:58 -0700 [thread overview]
Message-ID: <20140414152758.a9a80782dbb94c74a27f683a@linux-foundation.org> (raw)
In-Reply-To: <20140324125926.013008345@openvz.org>
On Mon, 24 Mar 2014 16:28:40 +0400 Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> Otherwise we may not notice that pte was softdirty.
>
> --- linux-2.6.git.orig/mm/memory.c
> +++ linux-2.6.git/mm/memory.c
> @@ -3422,7 +3422,7 @@ static int __do_fault(struct mm_struct *
> if (flags & FAULT_FLAG_WRITE)
> entry = maybe_mkwrite(pte_mkdirty(entry), vma);
> else if (pte_file(orig_pte) && pte_file_soft_dirty(orig_pte))
> - pte_mksoft_dirty(entry);
> + entry = pte_mksoft_dirty(entry);
> if (anon) {
> inc_mm_counter_fast(mm, MM_ANONPAGES);
> page_add_new_anon_rmap(page, vma, address);
This will need to be redone for current kernels, please. New patch, new
title, new changelog, retest.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-14 22:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 12:28 [patch 0/4] mm: A few memory tracker fixes Cyrill Gorcunov
2014-03-24 12:28 ` [patch 1/4] mm: Make freshly remapped file pages being softdirty unconditionally Cyrill Gorcunov
2014-03-24 12:28 ` [patch 2/4] mm: Dont forget to set softdirty on file mapped fault Cyrill Gorcunov
2014-04-14 22:27 ` Andrew Morton [this message]
2014-04-14 22:33 ` Cyrill Gorcunov
2014-04-14 22:38 ` Cyrill Gorcunov
2014-04-14 22:43 ` Andrew Morton
2014-03-24 12:28 ` [patch 3/4] mm: Dont forget to save file map softdiry bit on unmap Cyrill Gorcunov
2014-03-24 12:28 ` [patch 4/4] mm: Clear VM_SOFTDIRTY flag inside clear_refs_write instead of clear_soft_dirty Cyrill Gorcunov
2014-04-15 18:06 ` Andrew Morton
2014-04-15 18:29 ` Cyrill Gorcunov
2014-04-15 18:44 ` Andrew Morton
2014-04-15 18:48 ` Cyrill Gorcunov
2014-04-15 18:52 ` Andrew Morton
2014-04-16 7:05 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414152758.a9a80782dbb94c74a27f683a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).