Re: [PATCH 1/2] mm/compaction: clean up unused code lines

Vlastimil Babka
2014-04-07T14:40:16Z

On 04/03/2014 10:57 AM, Heesub Shin wrote:
> This commit removes code lines currently not in use or never called.
>
> Signed-off-by: Heesub Shin <heesub.shin@samsung.com>
> Cc: Dongjun Shin <d.j.shin@samsung.com>
> Cc: Sunghwan Yun <sunghwan.yun@samsung.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
> mm/compaction.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 9635083..1ef9144 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -208,12 +208,6 @@ static bool compact_checklock_irqsave(spinlock_t *lock, unsigned long *flags,
> return true;
> }
>
> -static inline bool compact_trylock_irqsave(spinlock_t *lock,
> - unsigned long *flags, struct compact_control *cc)
> -{
> - return compact_checklock_irqsave(lock, flags, false, cc);
> -}
> -
> /* Returns true if the page is within a block suitable for migration to */
> static bool suitable_migration_target(struct page *page)
> {
> @@ -728,7 +722,6 @@ static void isolate_freepages(struct zone *zone,
> continue;
>
> /* Found a block suitable for isolating free pages from */
> - isolated = 0;
>
> /*
> * As pfn may not start aligned, pfn+pageblock_nr_page
> @@ -1160,9 +1153,6 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc)
> if (zone_watermark_ok(zone, cc->order,
> low_wmark_pages(zone), 0, 0))
> compaction_defer_reset(zone, cc->order, false);
> - /* Currently async compaction is never deferred. */
> - else if (cc->sync)
> - defer_compaction(zone, cc->order);
> }
>
> VM_BUG_ON(!list_empty(&cc->freepages));