From: Vladimir Davydov <vdavydov@parallels.com>
To: akpm@linux-foundation.org
Cc: mhocko@suse.cz, hannes@cmpxchg.org, glommer@gmail.com,
cl@linux-foundation.org, penberg@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
devel@openvz.org
Subject: Re: [PATCH -mm 0/6] memcg/kmem: cleanup naming and callflows
Date: Sun, 27 Apr 2014 12:56:08 +0400 [thread overview]
Message-ID: <20140427085606.GA4183@esperanza> (raw)
In-Reply-To: <cover.1398428532.git.vdavydov@parallels.com>
Please ignore this set - I found that something can be improved, will
send v2 soon. Sorry for the noise.
Thanks.
On Fri, Apr 25, 2014 at 04:33:06PM +0400, Vladimir Davydov wrote:
> Hi,
>
> In reply to "[PATCH RFC -mm v2 3/3] memcg, slab: simplify
> synchronization scheme" Johannes wrote:
>
> > I like this patch, but the API names are confusing. Could we fix up
> > that whole thing by any chance?
>
> (see https://lkml.org/lkml/2014/4/18/317)
>
> So this patch set is about cleaning up memcg/kmem naming.
>
> While preparing it I found that some of the ugly-named functions
> constituting interface between memcontrol.c and slab_common.c can be
> neatly got rid of w/o complicating the code. Quite the contrary, w/o
> them call-flows look much simpler, IMO. So the first four patches do not
> rename anything actually - they just rework call-flows in kmem cache
> creation/destruction and memcg_caches arrays relocations paths. Finally,
> patches 5 and 6 clean up the naming.
>
> Reviews are appreciated.
>
> Thanks,
>
> Vladimir Davydov (6):
> memcg: get rid of memcg_create_cache_name
> memcg: allocate memcg_caches array on first per memcg cache creation
> memcg: cleanup memcg_caches arrays relocation path
> memcg: get rid of memcg_{alloc,free}_cache_params
> memcg: cleanup kmem cache creation/destruction functions naming
> memcg: cleanup kmem_id-related naming
>
> include/linux/memcontrol.h | 40 +----
> include/linux/slab.h | 12 +-
> mm/memcontrol.c | 420 ++++++++++++++++++++------------------------
> mm/slab.c | 4 +-
> mm/slab.h | 24 ++-
> mm/slab_common.c | 127 ++++++++++----
> mm/slub.c | 10 +-
> 7 files changed, 320 insertions(+), 317 deletions(-)
>
> --
> 1.7.10.4
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-04-27 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 12:33 [PATCH -mm 0/6] memcg/kmem: cleanup naming and callflows Vladimir Davydov
2014-04-25 12:33 ` [PATCH -mm 1/6] memcg: get rid of memcg_create_cache_name Vladimir Davydov
2014-04-25 12:33 ` [PATCH -mm 2/6] memcg: allocate memcg_caches array on first per memcg cache creation Vladimir Davydov
2014-04-25 12:33 ` [PATCH -mm 3/6] memcg: cleanup memcg_caches arrays relocation path Vladimir Davydov
2014-04-25 12:33 ` [PATCH -mm 4/6] memcg: get rid of memcg_{alloc,free}_cache_params Vladimir Davydov
2014-04-25 12:33 ` [PATCH -mm 5/6] memcg: cleanup kmem cache creation/destruction functions naming Vladimir Davydov
2014-04-25 12:33 ` [PATCH -mm 6/6] memcg: cleanup kmem_id-related naming Vladimir Davydov
2014-04-25 13:12 ` [PATCH -mm v1.1] " Vladimir Davydov
2014-04-27 8:56 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140427085606.GA4183@esperanza \
--to=vdavydov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=devel@openvz.org \
--cc=glommer@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).