From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com [209.85.217.171]) by kanga.kvack.org (Postfix) with ESMTP id 4AB176B004D for ; Sun, 27 Apr 2014 04:56:48 -0400 (EDT) Received: by mail-lb0-f171.google.com with SMTP id u14so1255037lbd.16 for ; Sun, 27 Apr 2014 01:56:47 -0700 (PDT) Received: from mx2.parallels.com (mx2.parallels.com. [199.115.105.18]) by mx.google.com with ESMTPS id am6si8236122lbc.66.2014.04.27.01.56.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Apr 2014 01:56:46 -0700 (PDT) Date: Sun, 27 Apr 2014 12:56:08 +0400 From: Vladimir Davydov Subject: Re: [PATCH -mm 0/6] memcg/kmem: cleanup naming and callflows Message-ID: <20140427085606.GA4183@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org Cc: mhocko@suse.cz, hannes@cmpxchg.org, glommer@gmail.com, cl@linux-foundation.org, penberg@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, devel@openvz.org Please ignore this set - I found that something can be improved, will send v2 soon. Sorry for the noise. Thanks. On Fri, Apr 25, 2014 at 04:33:06PM +0400, Vladimir Davydov wrote: > Hi, > > In reply to "[PATCH RFC -mm v2 3/3] memcg, slab: simplify > synchronization scheme" Johannes wrote: > > > I like this patch, but the API names are confusing. Could we fix up > > that whole thing by any chance? > > (see https://lkml.org/lkml/2014/4/18/317) > > So this patch set is about cleaning up memcg/kmem naming. > > While preparing it I found that some of the ugly-named functions > constituting interface between memcontrol.c and slab_common.c can be > neatly got rid of w/o complicating the code. Quite the contrary, w/o > them call-flows look much simpler, IMO. So the first four patches do not > rename anything actually - they just rework call-flows in kmem cache > creation/destruction and memcg_caches arrays relocations paths. Finally, > patches 5 and 6 clean up the naming. > > Reviews are appreciated. > > Thanks, > > Vladimir Davydov (6): > memcg: get rid of memcg_create_cache_name > memcg: allocate memcg_caches array on first per memcg cache creation > memcg: cleanup memcg_caches arrays relocation path > memcg: get rid of memcg_{alloc,free}_cache_params > memcg: cleanup kmem cache creation/destruction functions naming > memcg: cleanup kmem_id-related naming > > include/linux/memcontrol.h | 40 +---- > include/linux/slab.h | 12 +- > mm/memcontrol.c | 420 ++++++++++++++++++++------------------------ > mm/slab.c | 4 +- > mm/slab.h | 24 ++- > mm/slab_common.c | 127 ++++++++++---- > mm/slub.c | 10 +- > 7 files changed, 320 insertions(+), 317 deletions(-) > > -- > 1.7.10.4 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org