From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by kanga.kvack.org (Postfix) with ESMTP id CAB1D6B0036 for ; Tue, 29 Apr 2014 08:41:07 -0400 (EDT) Received: by mail-ee0-f45.google.com with SMTP id d17so279622eek.18 for ; Tue, 29 Apr 2014 05:41:07 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id d5si26818802eei.358.2014.04.29.05.41.05 for ; Tue, 29 Apr 2014 05:41:06 -0700 (PDT) Date: Tue, 29 Apr 2014 14:40:53 +0200 From: Oleg Nesterov Subject: Re: [BUG] kernel BUG at mm/vmacache.c:85! Message-ID: <20140429124053.GA11878@redhat.com> References: <535EA976.1080402@linux.vnet.ibm.com> <1398724754.25549.35.camel@buesod1.americas.hpqcorp.net> <20140428161120.4cad719dc321e3c837db3fd6@linux-foundation.org> <1398730319.25549.40.camel@buesod1.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398730319.25549.40.camel@buesod1.americas.hpqcorp.net> Sender: owner-linux-mm@kvack.org List-ID: To: Davidlohr Bueso Cc: Linus Torvalds , Andrew Morton , "Srivatsa S. Bhat" , Linux MM , "linux-kernel@vger.kernel.org" , Rik van Riel , Michel Lespinasse , Hugh Dickins On 04/28, Davidlohr Bueso wrote: > > @@ -29,6 +30,7 @@ void use_mm(struct mm_struct *mm) > tsk->active_mm = mm; > } > tsk->mm = mm; > + vmacache_flush(tsk); But this can't help, we need to do this in unuse_mm(). And we can race with vmacache_flush_all() which relies on mmap_sem. But perhaps WARN_ON(tsk->mm) at the start makes sense... Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org