From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by kanga.kvack.org (Postfix) with ESMTP id 264696B0037 for ; Thu, 1 May 2014 06:15:57 -0400 (EDT) Received: by mail-wi0-f175.google.com with SMTP id cc10so432576wib.2 for ; Thu, 01 May 2014 03:15:56 -0700 (PDT) Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by mx.google.com with ESMTPS id ft4si10545608wjb.205.2014.05.01.03.15.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 01 May 2014 03:15:55 -0700 (PDT) Received: by mail-we0-f170.google.com with SMTP id w61so2916333wes.29 for ; Thu, 01 May 2014 03:15:55 -0700 (PDT) Date: Thu, 1 May 2014 11:15:49 +0100 From: Steve Capper Subject: Re: [RFC PATCH V4 6/7] arm64: mm: Enable HAVE_RCU_TABLE_FREE logic Message-ID: <20140501101548.GA2254@linaro.org> References: <1396018892-6773-1-git-send-email-steve.capper@linaro.org> <1396018892-6773-7-git-send-email-steve.capper@linaro.org> <20140430152047.GF31220@arm.com> <20140430153317.GG31220@arm.com> <20140430153824.GA7166@linaro.org> <20140430172114.GI31220@arm.com> <20140501073402.GA30358@linaro.org> <20140501095246.GB22316@arm.com> <20140501095739.GO11096@twins.programming.kicks-ass.net> <20140501100415.GC22316@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140501100415.GC22316@arm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Catalin Marinas Cc: Peter Zijlstra , "linux-arm-kernel@lists.infradead.org" , "linux@arm.linux.org.uk" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" , "gary.robertson@linaro.org" , "anders.roxell@linaro.org" , "akpm@linux-foundation.org" On Thu, May 01, 2014 at 11:04:15AM +0100, Catalin Marinas wrote: > On Thu, May 01, 2014 at 10:57:39AM +0100, Peter Zijlstra wrote: > > On Thu, May 01, 2014 at 10:52:47AM +0100, Catalin Marinas wrote: > > > Does gup_fast walking increment the mm_users? Or is it a requirement of > > > the calling code? I can't seem to find where this happens. > > > > No, its not required at all. One should only walk current->mm with > > gup_fast, any other usage is broken. > > OK, I get it now. > > > And by delaying TLB shootdown, either through disabling IRQs and > > stalling IPIs or by using RCU freeing, you're guaranteed your own page > > tables won't disappear underneath your feet. > > And for RCU to work, we still need to use the full tlb_remove_table() > logic (Steve's patches just use tlb_remove_page() for table freeing). Yes, I see. This is a bug in the arm64 patch (arm correctly calls tlb_remove_page), I think it got ate during a rebase. I will fix the arm64 activation logic. Apologies for the confustion, -- Steve > > Thanks. > > -- > Catalin > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org