From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>, Jianyu Zhan <nasa4836@gmail.com>,
bsingharora@gmail.com, kamezawa.hiroyu@jp.fujitsu.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.com
Subject: Re: [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone()
Date: Mon, 5 May 2014 14:36:46 -0700 [thread overview]
Message-ID: <20140505143646.c0591119522b869b79d9c77b@linux-foundation.org> (raw)
In-Reply-To: <20140502232908.GQ23420@cmpxchg.org>
On Fri, 2 May 2014 19:29:08 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> Memcg zoneinfo lookup sites have either the page, the zone, or the
> node id and zone index, but sites that only have the zone have to look
> up the node id and zone index themselves, whereas sites that already
> have those two integers use a function for a simple pointer chase.
>
> Provide mem_cgroup_zone_zoneinfo() that takes a zone pointer and let
> sites that already have node id and zone index - all for each node,
> for each zone iterators - use &memcg->nodeinfo[nid]->zoneinfo[zid].
>
> Rename page_cgroup_zoneinfo() to mem_cgroup_page_zoneinfo() to match.
Patch shrinks my mm/memcontrol.o nicely:
text data bss dec hex filename
55702 15681 24560 95943 176c7 mm/memcontrol.o-before
55489 15681 24464 95634 17592 mm/memcontrol.o-after
The bss size changes are weird - the patch doesn't touch bss afaict.
This often happens. One day I'll get in there and work out why.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-05-05 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 23:01 [PATCH 2/2] mm/memcontrol.c: introduce helper mem_cgroup_zoneinfo_zone() Jianyu Zhan
2014-04-22 9:59 ` Michal Hocko
2014-04-28 15:04 ` Michal Hocko
2014-05-01 12:54 ` Johannes Weiner
2014-05-01 13:36 ` Johannes Weiner
2014-05-02 22:05 ` Andrew Morton
2014-05-02 23:29 ` Johannes Weiner
2014-05-02 23:31 ` Johannes Weiner
2014-05-05 15:35 ` Michal Hocko
2014-05-05 15:31 ` Michal Hocko
2014-05-05 21:36 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505143646.c0591119522b869b79d9c77b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akpm@linux-foundation.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nasa4836@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).