linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-mm <linux-mm@kvack.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC, PATCH 0/8] remap_file_pages() decommission
Date: Wed, 7 May 2014 09:46:01 -0700	[thread overview]
Message-ID: <20140507094601.0f7fd266.akpm@linux-foundation.org> (raw)
In-Reply-To: <20140507091258.GP11096@twins.programming.kicks-ass.net>

On Wed, 7 May 2014 11:12:58 +0200 Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, May 06, 2014 at 04:28:56PM -0700, Andrew Morton wrote:
> > On Wed, 7 May 2014 02:03:23 +0300 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> > 
> > > remap_file_pages(2) was invented to be able efficiently map parts of
> > > huge file into limited 32-bit virtual address space such as in database
> > > workloads.
> > > 
> > > Nonlinear mappings are pain to support and it seems there's no
> > > legitimate use-cases nowadays since 64-bit systems are widely available.
> > > 
> > > Let's deprecate remap_file_pages() syscall in hope to get rid of code
> > > one day.
> > 
> > Before we do this we should ensure that your proposed replacement is viable
> > and desirable.  If we later decide not to proceed with it, this patch will
> > sow confusion.
> 
> Chicken meet Egg ?
> 
> How are we supposed to test if its viable if we have no known users?

Same way we always do - finish the code, developer test, review, give
it a spin in linux-next, etc.  Do some microbenchmarking to get an
understanding of the impact on people who are using r_f_p for real. 
The current patchset looks rather alphaish.

> The
> printk() might maybe (hopefully) get us some reaction in say a years
> time, much longer if we're really unlucky.
> 
> That said, we could make the syscall return -ENOSYS unless a sysctl was
> touched. The printk() would indeed have to mention said sysctl and a
> place to find information about why we're doing this..
> 
> But by creating more pain (people have to actually set the sysctl, and
> we'll have to universally agree to inflict pain on distro people that
> set it by default -- say, starve them from beer at the next conf.) we're
> more likely to get an answer sooner.

Could be.  We should consult distro people, Oracle people...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2014-05-07 16:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 14:37 [RFC, PATCH 0/8] remap_file_pages() decommission Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 1/8] mm: replace remap_file_pages() syscall with emulation Kirill A. Shutemov
2014-10-08  6:50   ` Vineet Gupta
2014-10-08 10:03     ` Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 2/8] mm: kill vm_operations_struct->remap_pages Kirill A. Shutemov
2014-05-19 15:03   ` Christoph Hellwig
2014-05-19 15:14     ` Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 3/8] mm: kill zap_details->nonlinear_vma Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 4/8] mm, rmap: kill rmap_walk_control->file_nonlinear() Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 5/8] mm, rmap: kill vma->shared.nonlinear Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 6/8] mm, rmap: kill mapping->i_mmap_nonlinear Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 7/8] mm: kill VM_NONLINEAR and FAULT_FLAG_NONLINEAR Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 8/8] mm, x86: kill pte_to_pgoff(), pgoff_to_pte() and pte_file*() Kirill A. Shutemov
2014-05-06 21:35 ` [RFC, PATCH 0/8] remap_file_pages() decommission Andrew Morton
2014-05-06 21:51   ` Linus Torvalds
2014-05-06 23:03     ` Kirill A. Shutemov
2014-05-06 23:28       ` Andrew Morton
2014-05-07  9:12         ` Peter Zijlstra
2014-05-07 16:46           ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507094601.0f7fd266.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kirill@shutemov.name \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).