From: Andrew Morton <akpm@linux-foundation.org>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Michal Hocko <mhocko@suse.cz>,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH -mm 1/2] memcg: get rid of memcg_create_cache_name
Date: Wed, 7 May 2014 13:53:52 -0700 [thread overview]
Message-ID: <20140507135352.3790c739ae331d1f6721f3de@linux-foundation.org> (raw)
In-Reply-To: <20140507104514.GC4757@esperanza>
On Wed, 7 May 2014 14:45:16 +0400 Vladimir Davydov <vdavydov@parallels.com> wrote:
> @@ -3164,6 +3141,7 @@ void memcg_free_cache_params(struct kmem_cache *s)
> static void memcg_kmem_create_cache(struct mem_cgroup *memcg,
> struct kmem_cache *root_cache)
> {
> + static char *memcg_name_buf; /* protected by memcg_slab_mutex */
> struct kmem_cache *cachep;
> int id;
>
> @@ -3179,7 +3157,14 @@ static void memcg_kmem_create_cache(struct mem_cgroup *memcg,
> if (cache_from_memcg_idx(root_cache, id))
> return;
>
> - cachep = kmem_cache_create_memcg(memcg, root_cache);
> + if (!memcg_name_buf) {
> + memcg_name_buf = kmalloc(NAME_MAX + 1, GFP_KERNEL);
> + if (!memcg_name_buf)
> + return;
> + }
Does this have any meaningful advantage over the simpler
static char memcg_name_buf[NAME_MAX + 1];
?
I guess it saves a scrap of memory if the machine never uses memcg's.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-07 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 8:15 [PATCH -mm 1/2] memcg: get rid of memcg_create_cache_name Vladimir Davydov
2014-05-07 8:15 ` [PATCH -mm 2/2] memcg: cleanup kmem cache creation/destruction functions naming Vladimir Davydov
2014-05-07 12:45 ` Michal Hocko
2014-05-13 15:05 ` [PATCH -mm v2] " Vladimir Davydov
2014-05-14 9:40 ` Michal Hocko
2014-05-07 9:51 ` [PATCH -mm 1/2] memcg: get rid of memcg_create_cache_name Michal Hocko
2014-05-07 10:45 ` Vladimir Davydov
2014-05-07 11:19 ` Michal Hocko
2014-05-07 20:53 ` Andrew Morton [this message]
2014-05-08 7:08 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507135352.3790c739ae331d1f6721f3de@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).