From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, rientjes@google.com
Cc: cl@linux.com, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block()
Date: 7 May 2014 20:44:52 -0400 [thread overview]
Message-ID: <20140508004452.27923.qmail@ns.horizon.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405071502040.25024@chino.kir.corp.google.com>
> A function called clear_obj_pfmemalloc() doesn't indicate it's returning
> anything, I think the vast majority of people would believe that it
> returns void just as it does. There's no complier generated code
> optimization with this patch and
> I'm not sure it's even correct since
> you're now clearing after doing recheck_pfmemalloc_active().
I thought this through before rearranging the code.
recheck_pfmemalloc_active() checks global lists, but __ac_get_obj()
is doing clear_obj_pfmemalloc on a local variable.
I think it does make sense to remove the pointless "return;" in
set_obj_pfmemalloc(), however. Not sure it's worth asking someone to
merge it, though.
next prev parent reply other threads:[~2014-05-08 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 21:22 [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block() George Spelvin
2014-05-07 21:30 ` David Rientjes
2014-05-07 21:50 ` George Spelvin
2014-05-07 22:05 ` David Rientjes
2014-05-08 0:44 ` George Spelvin [this message]
2014-05-08 1:46 ` George Spelvin
2014-05-08 13:51 ` Christoph Lameter
2014-05-08 19:24 ` George Spelvin
-- strict thread matches above, loose matches on Subject: below --
2014-05-07 6:06 [PATCH v2 00/10] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
2014-05-07 6:06 ` [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block() Joonsoo Kim
2014-05-08 0:52 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508004452.27923.qmail@ns.horizon.com \
--to=linux@horizon.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).