* [PATCH] mm: remap_file_pages: initialize populate before usage
@ 2014-05-12 12:40 Sasha Levin
2014-05-12 17:05 ` Kirill A. Shutemov
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2014-05-12 12:40 UTC (permalink / raw)
To: akpm, kirill.shutemov; +Cc: linux-mm, linux-kernel, Sasha Levin
'populate' wasn't initialized before being used in error paths,
causing panics when mm_populate() would get called with invalid
values.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
mm/mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index 84dcfc7..2a0e0a8 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2591,7 +2591,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
struct mm_struct *mm = current->mm;
struct vm_area_struct *vma;
- unsigned long populate;
+ unsigned long populate = 0;
unsigned long ret = -EINVAL;
pr_warn_once("%s (%d) uses deprecated remap_file_pages() syscall. "
--
1.7.10.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: remap_file_pages: initialize populate before usage
2014-05-12 12:40 [PATCH] mm: remap_file_pages: initialize populate before usage Sasha Levin
@ 2014-05-12 17:05 ` Kirill A. Shutemov
0 siblings, 0 replies; 2+ messages in thread
From: Kirill A. Shutemov @ 2014-05-12 17:05 UTC (permalink / raw)
To: Sasha Levin; +Cc: akpm, kirill.shutemov, linux-mm, linux-kernel
On Mon, May 12, 2014 at 08:40:54AM -0400, Sasha Levin wrote:
> 'populate' wasn't initialized before being used in error paths,
> causing panics when mm_populate() would get called with invalid
> values.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 84dcfc7..2a0e0a8 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2591,7 +2591,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size,
>
> struct mm_struct *mm = current->mm;
> struct vm_area_struct *vma;
> - unsigned long populate;
> + unsigned long populate = 0;
> unsigned long ret = -EINVAL;
>
> pr_warn_once("%s (%d) uses deprecated remap_file_pages() syscall. "
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-12 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 12:40 [PATCH] mm: remap_file_pages: initialize populate before usage Sasha Levin
2014-05-12 17:05 ` Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).