From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by kanga.kvack.org (Postfix) with ESMTP id 874696B003A for ; Tue, 13 May 2014 14:23:07 -0400 (EDT) Received: by mail-we0-f176.google.com with SMTP id q59so797094wes.35 for ; Tue, 13 May 2014 11:23:06 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id ym1si5951270wjc.38.2014.05.13.11.23.05 for ; Tue, 13 May 2014 11:23:06 -0700 (PDT) Date: Tue, 13 May 2014 20:22:10 +0200 From: Oleg Nesterov Subject: Re: [PATCH 19/19] mm: filemap: Avoid unnecessary barries and waitqueue lookups in unlock_page fastpath Message-ID: <20140513182210.GC12123@redhat.com> References: <1399974350-11089-1-git-send-email-mgorman@suse.de> <1399974350-11089-20-git-send-email-mgorman@suse.de> <20140513125313.GR23991@suse.de> <20140513141748.GD2485@laptop.programming.kicks-ass.net> <20140513152719.GF18164@linux.vnet.ibm.com> <20140513154435.GG2485@laptop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140513154435.GG2485@laptop.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: "Paul E. McKenney" , Mel Gorman , Andrew Morton , Johannes Weiner , Vlastimil Babka , Jan Kara , Michal Hocko , Hugh Dickins , Dave Hansen , Linux Kernel , Linux-MM , Linux-FSDevel , Linus Torvalds , David Howells On 05/13, Peter Zijlstra wrote: > > Ah, yes, so I'll defer to Oleg and Linus to explain that one. As per the > name: smp_mb__before_spinlock() should of course imply a full barrier. Oh yes, I agree, the name is confusing. At least the comment tries to explain what it does. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org