From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by kanga.kvack.org (Postfix) with ESMTP id C51366B0035 for ; Thu, 29 May 2014 20:21:27 -0400 (EDT) Received: by mail-pa0-f52.google.com with SMTP id bj1so731925pad.39 for ; Thu, 29 May 2014 17:21:27 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net. [2001:44b8:8060:ff02:300:1:6:6]) by mx.google.com with ESMTP id ty7si3136729pab.10.2014.05.29.17.21.26 for ; Thu, 29 May 2014 17:21:26 -0700 (PDT) Date: Fri, 30 May 2014 10:21:13 +1000 From: Dave Chinner Subject: Re: [RFC 2/2] x86_64: expand kernel stack to 16K Message-ID: <20140530002113.GC14410@dastard> References: <1401260039-18189-2-git-send-email-minchan@kernel.org> <20140528223142.GO8554@dastard> <20140529013007.GF6677@dastard> <20140529072633.GH6677@dastard> <20140529235308.GA14410@dastard> <20140530000649.GA3477@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140530000649.GA3477@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Dave Jones , Linus Torvalds , Jens Axboe , Minchan Kim , Linux Kernel Mailing List , Andrew Morton , linux-mm , "H. Peter Anvin" , Ingo Molnar , Peter Zijlstra , Mel Gorman , Rik van Riel , Johannes Weiner , Hugh Dickins , Rusty Russell , "Michael S. Tsirkin" , Dave Hansen , Steven Rostedt On Thu, May 29, 2014 at 08:06:49PM -0400, Dave Jones wrote: > On Fri, May 30, 2014 at 09:53:08AM +1000, Dave Chinner wrote: > > > That sounds like a plan. Perhaps it would be useful to add a > > WARN_ON_ONCE(stack_usage > 8k) (or some other arbitrary depth beyond > > 8k) so that we get some indication that we're hitting a deep stack > > but the system otherwise keeps functioning. That gives us some > > motivation to keep stack usage down but isn't a fatal problem like > > it is now.... > > We have check_stack_usage() and DEBUG_STACK_USAGE for this. > Though it needs some tweaking if we move to 16K Right, but it doesn't throw loud warnings when a specific threshold is reached - it just issues a quiet message when a process exits telling you what the maximum was without giving us a stack to chew on.... Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org