From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id 761AC900002 for ; Thu, 12 Jun 2014 03:52:42 -0400 (EDT) Received: by mail-pd0-f172.google.com with SMTP id fp1so705041pdb.17 for ; Thu, 12 Jun 2014 00:52:42 -0700 (PDT) Received: from lgemrelse6q.lge.com (LGEMRELSE6Q.lge.com. [156.147.1.121]) by mx.google.com with ESMTP id ho3si208244pad.181.2014.06.12.00.52.40 for ; Thu, 12 Jun 2014 00:52:41 -0700 (PDT) Date: Thu, 12 Jun 2014 16:56:38 +0900 From: Joonsoo Kim Subject: Re: [PATCH v2 10/10] mm, cma: use spinlock instead of mutex Message-ID: <20140612075638.GD20199@js1304-P5Q-DELUXE> References: <1402543307-29800-1-git-send-email-iamjoonsoo.kim@lge.com> <1402543307-29800-11-git-send-email-iamjoonsoo.kim@lge.com> <20140612074029.GB12663@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140612074029.GB12663@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , "Aneesh Kumar K.V" , Marek Szyprowski , Michal Nazarewicz , Russell King - ARM Linux , Greg Kroah-Hartman , Paolo Bonzini , Gleb Natapov , Alexander Graf , Benjamin Herrenschmidt , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On Thu, Jun 12, 2014 at 04:40:29PM +0900, Minchan Kim wrote: > On Thu, Jun 12, 2014 at 12:21:47PM +0900, Joonsoo Kim wrote: > > Currently, we should take the mutex for manipulating bitmap. > > This job may be really simple and short so we don't need to sleep > > if contended. So I change it to spinlock. > > I'm not sure it would be good always. > Maybe you remember we discussed about similar stuff about bitmap > searching in vmap friend internally, which was really painful > when it was fragmented. So, at least we need number if you really want > and I hope the number from ARM machine most popular platform for CMA > at the moment. Good Point!! Agreed. I will drop this one in next spin and re-submit in separate patchset after some testing. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org