From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by kanga.kvack.org (Postfix) with ESMTP id 1B9D86B0031 for ; Mon, 16 Jun 2014 19:42:40 -0400 (EDT) Received: by mail-pa0-f50.google.com with SMTP id bj1so3247943pad.9 for ; Mon, 16 Jun 2014 16:42:39 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTP id ss10si15228224pab.209.2014.06.16.16.42.39 for ; Mon, 16 Jun 2014 16:42:39 -0700 (PDT) Date: Mon, 16 Jun 2014 16:42:37 -0700 From: Andrew Morton Subject: Re: [PATCH] mm/vmscan.c: avoid recording the original scan targets in shrink_lruvec() Message-Id: <20140616164237.5fcba7baaec83d509c9683e0@linux-foundation.org> In-Reply-To: <1402923474.3958.34.camel@debian> References: <1402320436-22270-1-git-send-email-slaoub@gmail.com> <1402923474.3958.34.camel@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Chen Yucong Cc: mhocko@suse.cz, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, 16 Jun 2014 20:57:54 +0800 Chen Yucong wrote: > On Mon, 2014-06-09 at 21:27 +0800, Chen Yucong wrote: > > Via https://lkml.org/lkml/2013/4/10/334 , we can find that recording the > > original scan targets introduces extra 40 bytes on the stack. This patch > > is able to avoid this situation and the call to memcpy(). At the same time, > > it does not change the relative design idea. > > > > ratio = original_nr_file / original_nr_anon; > > > > If (nr_file > nr_anon), then ratio = (nr_file - x) / nr_anon. > > x = nr_file - ratio * nr_anon; > > > > if (nr_file <= nr_anon), then ratio = nr_file / (nr_anon - x). > > x = nr_anon - nr_file / ratio; > > > Hi Andrew Morton, > > I think the patch > > [PATCH] > mm-vmscanc-avoid-recording-the-original-scan-targets-in-shrink_lruvec-fix.patch > > which I committed should be discarded. OK, thanks. I assume you're referring to mm-vmscanc-avoid-recording-the-original-scan-targets-in-shrink_lruvec.patch - I don't think a -fix.patch existed? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org