From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chen Yucong <slaoub@gmail.com>,
mhocko@suse.cz, hannes@cmpxchg.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan.c: avoid recording the original scan targets in shrink_lruvec()
Date: Tue, 17 Jun 2014 08:51:17 +0900 [thread overview]
Message-ID: <20140616235117.GD18790@bbox> (raw)
In-Reply-To: <20140616164237.5fcba7baaec83d509c9683e0@linux-foundation.org>
On Mon, Jun 16, 2014 at 04:42:37PM -0700, Andrew Morton wrote:
> On Mon, 16 Jun 2014 20:57:54 +0800 Chen Yucong <slaoub@gmail.com> wrote:
>
> > On Mon, 2014-06-09 at 21:27 +0800, Chen Yucong wrote:
> > > Via https://lkml.org/lkml/2013/4/10/334 , we can find that recording the
> > > original scan targets introduces extra 40 bytes on the stack. This patch
> > > is able to avoid this situation and the call to memcpy(). At the same time,
> > > it does not change the relative design idea.
> > >
> > > ratio = original_nr_file / original_nr_anon;
> > >
> > > If (nr_file > nr_anon), then ratio = (nr_file - x) / nr_anon.
> > > x = nr_file - ratio * nr_anon;
> > >
> > > if (nr_file <= nr_anon), then ratio = nr_file / (nr_anon - x).
> > > x = nr_anon - nr_file / ratio;
> > >
> > Hi Andrew Morton,
> >
> > I think the patch
> >
> > [PATCH]
> > mm-vmscanc-avoid-recording-the-original-scan-targets-in-shrink_lruvec-fix.patch
> >
> > which I committed should be discarded.
>
> OK, thanks.
>
> I assume you're referring to
> mm-vmscanc-avoid-recording-the-original-scan-targets-in-shrink_lruvec.patch
True.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-06-16 23:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 13:27 [PATCH] mm/vmscan.c: avoid recording the original scan targets in shrink_lruvec() Chen Yucong
2014-06-09 23:24 ` Minchan Kim
2014-06-10 0:10 ` Chen Yucong
2014-06-10 0:24 ` Minchan Kim
2014-06-10 23:33 ` Andrew Morton
2014-06-11 2:08 ` Chen Yucong
2014-06-11 3:21 ` Chen Yucong
2014-06-16 0:47 ` Hugh Dickins
2014-06-16 6:21 ` Chen Yucong
2014-06-16 12:57 ` Chen Yucong
2014-06-16 23:42 ` Andrew Morton
2014-06-16 23:50 ` Chen Yucong
2014-06-16 23:51 ` Minchan Kim [this message]
2014-06-16 23:46 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616235117.GD18790@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=slaoub@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).