* arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
@ 2014-06-18 23:01 kbuild test robot
2014-06-18 23:09 ` David Rientjes
2014-06-18 23:20 ` Andrew Morton
0 siblings, 2 replies; 6+ messages in thread
From: kbuild test robot @ 2014-06-18 23:01 UTC (permalink / raw)
To: Will Woods; +Cc: Linux Memory Management List, Andrew Morton, kbuild-all
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e99cfa2d0634881b8a41d56c48b5956b9a3ba162
commit: 1e2ee49f7f1b79f0b14884fe6a602f0411b39552 fanotify: fix -EOVERFLOW with large files on 64-bit
date: 6 weeks ago
config: make ARCH=ia64 allmodconfig
All error/warnings:
fs/notify/fanotify/fanotify_user.c: In function 'SYSC_fanotify_init':
fs/notify/fanotify/fanotify_user.c:701:2: error: implicit declaration of function 'personality' [-Werror=implicit-function-declaration]
if (force_o_largefile())
^
In file included from include/uapi/linux/fcntl.h:4:0,
from include/linux/fcntl.h:4,
from fs/notify/fanotify/fanotify_user.c:2:
>> arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared (first use in this function)
(personality(current->personality) != PER_LINUX32)
^
fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
if (force_o_largefile())
^
arch/ia64/include/uapi/asm/fcntl.h:9:41: note: each undeclared identifier is reported only once for each function it appears in
(personality(current->personality) != PER_LINUX32)
^
fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
if (force_o_largefile())
^
cc1: some warnings being treated as errors
vim +/PER_LINUX32 +9 arch/ia64/include/uapi/asm/fcntl.h
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 1 #ifndef _ASM_IA64_FCNTL_H
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 2 #define _ASM_IA64_FCNTL_H
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 3 /*
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 4 * Modified 1998-2000
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 5 * David Mosberger-Tang <davidm@hpl.hp.com>, Hewlett-Packard Co.
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 6 */
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 7
ff67b597 include/asm-ia64/fcntl.h Tony Luck 2005-08-30 8 #define force_o_largefile() \
ff67b597 include/asm-ia64/fcntl.h Tony Luck 2005-08-30 @9 (personality(current->personality) != PER_LINUX32)
ef3daeda include/asm-ia64/fcntl.h Yoav Zach 2005-06-23 10
9317259e include/asm-ia64/fcntl.h Stephen Rothwell 2005-09-06 11 #include <asm-generic/fcntl.h>
9317259e include/asm-ia64/fcntl.h Stephen Rothwell 2005-09-06 12
^1da177e include/asm-ia64/fcntl.h Linus Torvalds 2005-04-16 13 #endif /* _ASM_IA64_FCNTL_H */
:::::: The code at line 9 was first introduced by commit
:::::: ff67b59726a8cd3549b069dfa78de2f538d3b8e3 [IA64] Low byte of current->personality is not a bitmask.
:::::: TO: Tony Luck <tony.luck@intel.com>
:::::: CC: Tony Luck <tony.luck@intel.com>
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
2014-06-18 23:01 arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared kbuild test robot
@ 2014-06-18 23:09 ` David Rientjes
2014-06-18 23:30 ` Andrew Morton
2014-06-18 23:20 ` Andrew Morton
1 sibling, 1 reply; 6+ messages in thread
From: David Rientjes @ 2014-06-18 23:09 UTC (permalink / raw)
To: kbuild test robot
Cc: Will Woods, Linux Memory Management List, Andrew Morton,
kbuild-all
On Thu, 19 Jun 2014, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: e99cfa2d0634881b8a41d56c48b5956b9a3ba162
> commit: 1e2ee49f7f1b79f0b14884fe6a602f0411b39552 fanotify: fix -EOVERFLOW with large files on 64-bit
> date: 6 weeks ago
> config: make ARCH=ia64 allmodconfig
>
> All error/warnings:
>
> fs/notify/fanotify/fanotify_user.c: In function 'SYSC_fanotify_init':
> fs/notify/fanotify/fanotify_user.c:701:2: error: implicit declaration of function 'personality' [-Werror=implicit-function-declaration]
> if (force_o_largefile())
> ^
> In file included from include/uapi/linux/fcntl.h:4:0,
> from include/linux/fcntl.h:4,
> from fs/notify/fanotify/fanotify_user.c:2:
> >> arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared (first use in this function)
> (personality(current->personality) != PER_LINUX32)
> ^
> fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
> if (force_o_largefile())
> ^
> arch/ia64/include/uapi/asm/fcntl.h:9:41: note: each undeclared identifier is reported only once for each function it appears in
> (personality(current->personality) != PER_LINUX32)
> ^
> fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
> if (force_o_largefile())
> ^
> cc1: some warnings being treated as errors
>
I think this wants to add #include <linux/personality.h> to
arch/ia64/include/uapi/asm/fcntl.h. I don't think we should be adding it
to fs/notify/fanotify/fanotify_user.c if
arch/ia64/include/uapi/asm/fcntl.h strictly requires it.
Yay for build errors reported six weeks later and after 3.15 had been
released.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
2014-06-18 23:09 ` David Rientjes
@ 2014-06-18 23:30 ` Andrew Morton
2014-06-19 16:25 ` Tony Luck
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2014-06-18 23:30 UTC (permalink / raw)
To: David Rientjes
Cc: kbuild test robot, Will Woods, Linux Memory Management List,
kbuild-all, Tony Luck
On Wed, 18 Jun 2014 16:09:26 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> Yay for build errors reported six weeks later and after 3.15 had been
> released.
ia64 allmodconfig has other problems in 3.15:
In file included from drivers/nfc/pn544/i2c.c:30:
include/linux/unaligned/access_ok.h:7: error: redefinition of 'get_unaligned_le16'
include/linux/unaligned/le_struct.h:6: note: previous definition of 'get_unaligned_le16' was here
include/linux/unaligned/access_ok.h:12: error: redefinition of 'get_unaligned_le32'
include/linux/unaligned/le_struct.h:11: note: previous definition of 'get_unaligned_le32' was here
...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
2014-06-18 23:30 ` Andrew Morton
@ 2014-06-19 16:25 ` Tony Luck
2014-06-19 18:13 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Tony Luck @ 2014-06-19 16:25 UTC (permalink / raw)
To: Andrew Morton
Cc: David Rientjes, kbuild test robot, Will Woods,
Linux Memory Management List, kbuild-all
On Wed, Jun 18, 2014 at 4:30 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> ia64 allmodconfig has other problems in 3.15:
>
> In file included from drivers/nfc/pn544/i2c.c:30:
> include/linux/unaligned/access_ok.h:7: error: redefinition of 'get_unaligned_le16'
I don't regularly build allmodconfig ... so this stuff slips by. It's
hard to build up
enthusiasm for making a NFC driver work on ia64. I don't see a lot of people
pulling a 200lb 4U server off the rack and hauling it to the subway so they can
buy a ticket by bumping it against the ticket machine.
-Tony
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
2014-06-19 16:25 ` Tony Luck
@ 2014-06-19 18:13 ` Andrew Morton
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2014-06-19 18:13 UTC (permalink / raw)
To: Tony Luck
Cc: David Rientjes, kbuild test robot, Will Woods,
Linux Memory Management List, kbuild-all
On Thu, 19 Jun 2014 09:25:42 -0700 Tony Luck <tony.luck@gmail.com> wrote:
> On Wed, Jun 18, 2014 at 4:30 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > ia64 allmodconfig has other problems in 3.15:
> >
> > In file included from drivers/nfc/pn544/i2c.c:30:
> > include/linux/unaligned/access_ok.h:7: error: redefinition of 'get_unaligned_le16'
>
> I don't regularly build allmodconfig ... so this stuff slips by. It's
> hard to build up
> enthusiasm for making a NFC driver work on ia64. I don't see a lot of people
> pulling a 200lb 4U server off the rack and hauling it to the subway so they can
> buy a ticket by bumping it against the ticket machine.
I expect this is a snafu in the header files, not nfc..
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
2014-06-18 23:01 arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared kbuild test robot
2014-06-18 23:09 ` David Rientjes
@ 2014-06-18 23:20 ` Andrew Morton
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2014-06-18 23:20 UTC (permalink / raw)
To: kbuild test robot
Cc: Will Woods, Linux Memory Management List, kbuild-all, Luck, Tony
On Thu, 19 Jun 2014 07:01:18 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: e99cfa2d0634881b8a41d56c48b5956b9a3ba162
> commit: 1e2ee49f7f1b79f0b14884fe6a602f0411b39552 fanotify: fix -EOVERFLOW with large files on 64-bit
> date: 6 weeks ago
> config: make ARCH=ia64 allmodconfig
>
> All error/warnings:
>
> fs/notify/fanotify/fanotify_user.c: In function 'SYSC_fanotify_init':
> fs/notify/fanotify/fanotify_user.c:701:2: error: implicit declaration of function 'personality' [-Werror=implicit-function-declaration]
> if (force_o_largefile())
> ^
> In file included from include/uapi/linux/fcntl.h:4:0,
> from include/linux/fcntl.h:4,
> from fs/notify/fanotify/fanotify_user.c:2:
> >> arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared (first use in this function)
> (personality(current->personality) != PER_LINUX32)
> ^
> fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
> if (force_o_largefile())
> ^
> arch/ia64/include/uapi/asm/fcntl.h:9:41: note: each undeclared identifier is reported only once for each function it appears in
> (personality(current->personality) != PER_LINUX32)
> ^
> fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
> if (force_o_largefile())
> ^
> cc1: some warnings being treated as errors
Thanks. This works for me:
From: Andrew Morton <akpm@linux-foundation.org>
Subject: ia64: arch/ia64/include/uapi/asm/fcntl.h needs personality.h
fs/notify/fanotify/fanotify_user.c: In function 'SYSC_fanotify_init':
fs/notify/fanotify/fanotify_user.c:726: error: implicit declaration of function 'personality'
fs/notify/fanotify/fanotify_user.c:726: error: 'PER_LINUX32' undeclared (first use in this function)
fs/notify/fanotify/fanotify_user.c:726: error: (Each undeclared identifier is reported only once
fs/notify/fanotify/fanotify_user.c:726: error: for each function it appears in.)
Reported-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: Will Woods <wwoods@redhat.com>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: <stable@vger.kernel.org> [3.15.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/ia64/include/uapi/asm/fcntl.h | 1 +
1 file changed, 1 insertion(+)
diff -puN arch/ia64/include/uapi/asm/fcntl.h~ia64-arch-ia64-include-uapi-asm-fcntlh-needs-personalityh arch/ia64/include/uapi/asm/fcntl.h
--- a/arch/ia64/include/uapi/asm/fcntl.h~ia64-arch-ia64-include-uapi-asm-fcntlh-needs-personalityh
+++ a/arch/ia64/include/uapi/asm/fcntl.h
@@ -8,6 +8,7 @@
#define force_o_largefile() \
(personality(current->personality) != PER_LINUX32)
+#include <linux/personality.h>
#include <asm-generic/fcntl.h>
#endif /* _ASM_IA64_FCNTL_H */
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-19 18:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 23:01 arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared kbuild test robot
2014-06-18 23:09 ` David Rientjes
2014-06-18 23:30 ` Andrew Morton
2014-06-19 16:25 ` Tony Luck
2014-06-19 18:13 ` Andrew Morton
2014-06-18 23:20 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).