linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	kbuild-all@01.org
Subject: Re: [next:master 182/217] include/linux/compiler.h:109:18: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'long unsigned int'
Date: Fri, 20 Jun 2014 12:15:32 -0700	[thread overview]
Message-ID: <20140620121532.6fd1279fd270e5109dd66693@linux-foundation.org> (raw)
In-Reply-To: <53a40933.iohxcHMNyZQcSVyQ%fengguang.wu@intel.com>

On Fri, 20 Jun 2014 18:13:07 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   633594bb2d3890711a887897f2003f41735f0dfa
> commit: 8d9dfa4b0125b04eb215909a388cf83fcdeee719 [182/217] initramfs: support initramfs that is more than 2G
> config: i386-randconfig-j1-06201406 (attached as .config)
> 
> All warnings:
> 
>    In file included from include/linux/init.h:4:0,
>                     from crypto/zlib.c:25:
>    crypto/zlib.c: In function 'zlib_compress_update':
>    include/linux/compiler.h:109:18: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'uLong' [-Wformat=]
>        static struct ftrace_branch_data  \

Simple fix is below.

But things still aren't very good. 
initramfs-support-initramfs-that-is-more-than-2g.patch switches
avail_in and avail_out from uint to ulong but failed to fix up a whole
bunch of code which expects to handle 32-bit quantities.

eg:

static int zlib_compress_update(struct crypto_pcomp *tfm,
				struct comp_request *req)
{
	int ret;

	...

	ret = req->avail_out - stream->avail_out;

This is at least sloppy and is quite possibly buggy.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2014-06-20 19:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20 10:13 [next:master 182/217] include/linux/compiler.h:109:18: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'long unsigned int' kbuild test robot
2014-06-20 19:15 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140620121532.6fd1279fd270e5109dd66693@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).