* [mmotm:master 131/230] kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used [not found] <53a39bf2./ABA70PSoAso2CXo%fengguang.wu@intel.com> @ 2014-06-20 2:58 ` Fengguang Wu 2014-06-23 1:18 ` Johannes Weiner 0 siblings, 1 reply; 2+ messages in thread From: Fengguang Wu @ 2014-06-20 2:58 UTC (permalink / raw) To: Andrew Morton; +Cc: Linux Memory Management List, Johannes Weiner, kbuild-all tree: git://git.cmpxchg.org/linux-mmotm.git master head: df25ba7db0775d87018e2cd92f26b9b087093840 commit: 9e458f8e3d973f459b8c8fef50e15012764f7998 [131/230] mm-memcontrol-rewrite-charge-api-fix config: make ARCH=i386 allyesconfig All warnings: kernel/events/uprobes.c: In function 'uprobe_write_opcode': >> kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used [-Wunused-label] put_new: ^ vim +/put_new +330 kernel/events/uprobes.c 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 314 ret = -ENOMEM; 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 315 new_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vaddr); 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 316 if (!new_page) 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 317 goto put_old; 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 318 9e458f8e kernel/events/uprobes.c Andrew Morton 2014-06-20 319 // if (mem_cgroup_charge_anon(new_page, mm, GFP_KERNEL)) 9e458f8e kernel/events/uprobes.c Andrew Morton 2014-06-20 320 // goto put_new; 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 321 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 322 __SetPageUptodate(new_page); 3f47107c kernel/events/uprobes.c Oleg Nesterov 2013-03-24 323 copy_highpage(new_page, old_page); 3f47107c kernel/events/uprobes.c Oleg Nesterov 2013-03-24 324 copy_to_page(new_page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE); 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 325 c517ee74 kernel/events/uprobes.c Oleg Nesterov 2012-07-29 326 ret = __replace_page(vma, vaddr, old_page, new_page); 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 327 if (ret) 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 328 mem_cgroup_uncharge_page(new_page); 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 329 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 @330 put_new: 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 331 page_cache_release(new_page); 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 332 put_old: 7b2d81d4 kernel/uprobes.c Ingo Molnar 2012-02-17 333 put_page(old_page); 7b2d81d4 kernel/uprobes.c Ingo Molnar 2012-02-17 334 5323ce71 kernel/events/uprobes.c Oleg Nesterov 2012-06-15 335 if (unlikely(ret == -EAGAIN)) 5323ce71 kernel/events/uprobes.c Oleg Nesterov 2012-06-15 336 goto retry; 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 337 return ret; 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 338 } --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [mmotm:master 131/230] kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used 2014-06-20 2:58 ` [mmotm:master 131/230] kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used Fengguang Wu @ 2014-06-23 1:18 ` Johannes Weiner 0 siblings, 0 replies; 2+ messages in thread From: Johannes Weiner @ 2014-06-23 1:18 UTC (permalink / raw) To: Fengguang Wu; +Cc: Andrew Morton, Linux Memory Management List, kbuild-all On Fri, Jun 20, 2014 at 10:58:00AM +0800, Fengguang Wu wrote: > tree: git://git.cmpxchg.org/linux-mmotm.git master > head: df25ba7db0775d87018e2cd92f26b9b087093840 > commit: 9e458f8e3d973f459b8c8fef50e15012764f7998 [131/230] mm-memcontrol-rewrite-charge-api-fix > config: make ARCH=i386 allyesconfig > > All warnings: > > kernel/events/uprobes.c: In function 'uprobe_write_opcode': > >> kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used [-Wunused-label] > put_new: > ^ > > vim +/put_new +330 kernel/events/uprobes.c > > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 314 ret = -ENOMEM; > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 315 new_page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vaddr); > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 316 if (!new_page) > 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 317 goto put_old; > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 318 > 9e458f8e kernel/events/uprobes.c Andrew Morton 2014-06-20 319 // if (mem_cgroup_charge_anon(new_page, mm, GFP_KERNEL)) > 9e458f8e kernel/events/uprobes.c Andrew Morton 2014-06-20 320 // goto put_new; > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 321 > 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 322 __SetPageUptodate(new_page); > 3f47107c kernel/events/uprobes.c Oleg Nesterov 2013-03-24 323 copy_highpage(new_page, old_page); > 3f47107c kernel/events/uprobes.c Oleg Nesterov 2013-03-24 324 copy_to_page(new_page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE); > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 325 > c517ee74 kernel/events/uprobes.c Oleg Nesterov 2012-07-29 326 ret = __replace_page(vma, vaddr, old_page, new_page); > 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 327 if (ret) > 29dedee0 kernel/events/uprobes.c Oleg Nesterov 2014-05-05 328 mem_cgroup_uncharge_page(new_page); > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 329 > 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 @330 put_new: > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 331 page_cache_release(new_page); > 9f92448c kernel/events/uprobes.c Oleg Nesterov 2012-07-29 332 put_old: > 7b2d81d4 kernel/uprobes.c Ingo Molnar 2012-02-17 333 put_page(old_page); > 7b2d81d4 kernel/uprobes.c Ingo Molnar 2012-02-17 334 > 5323ce71 kernel/events/uprobes.c Oleg Nesterov 2012-06-15 335 if (unlikely(ret == -EAGAIN)) > 5323ce71 kernel/events/uprobes.c Oleg Nesterov 2012-06-15 336 goto retry; > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 337 return ret; > 2b144498 kernel/uprobes.c Srikar Dronamraju 2012-02-09 338 } This one is also fixed with the replacement patch that switches uprobes over to the new memcg charge API. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-23 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <53a39bf2./ABA70PSoAso2CXo%fengguang.wu@intel.com>
2014-06-20 2:58 ` [mmotm:master 131/230] kernel/events/uprobes.c:330:1: warning: label 'put_new' defined but not used Fengguang Wu
2014-06-23 1:18 ` Johannes Weiner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).