linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: remove remove_from_page_cache note
Date: Tue, 24 Jun 2014 11:25:11 +0200	[thread overview]
Message-ID: <20140624092511.GC15337@dhcp22.suse.cz> (raw)
In-Reply-To: <1403601462-32167-1-git-send-email-lilei@linux.vnet.ibm.com>

On Tue 24-06-14 17:17:42, Lei Li wrote:
> Remove this note as remove_from_page_cache has been renamed to
> delete_from_page_cache since Commit 702cfbf9 ("mm: goodbye
> remove_from_page_cache()"), and it doesn't serve any useful
> purpose.
> 
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>

I am not sure how up-to-date the file is but this small clean up will
not hurt.

Acked-by: Michal Hocko <mhocko@suse.cz>

> ---
>  Documentation/cgroups/memcg_test.txt | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
> index 8870b02..67c11a3 100644
> --- a/Documentation/cgroups/memcg_test.txt
> +++ b/Documentation/cgroups/memcg_test.txt
> @@ -82,8 +82,6 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
>  	- add_to_page_cache_locked().
>  
>  	The logic is very clear. (About migration, see below)
> -	Note: __remove_from_page_cache() is called by remove_from_page_cache()
> -	and __remove_mapping().
>  
>  6. Shmem(tmpfs) Page Cache
>  	The best way to understand shmem's page state transition is to read
> -- 
> 1.8.5.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2014-06-24  9:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  9:17 [PATCH] Documentation: remove remove_from_page_cache note Lei Li
2014-06-24  9:25 ` Michal Hocko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140624092511.GC15337@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=cgroups@vger.kernel.org \
    --cc=lilei@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).