linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Jerome Glisse <j.glisse-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sherry Cheung <SCheung-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
	<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	"Gabbay, Oded" <Oded.Gabbay-5C7GfCeVMHo@public.gmane.org>,
	"hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org"
	<hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	"aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jatin Kumar <jakumar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Lucien Dunning <ldunning-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"mgorman-l3A5Bk7waGM@public.gmane.org"
	<mgorman-l3A5Bk7waGM@public.gmane.org>,
	"jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Subhash Gutti <sgutti-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Bridgman, John" <John.Bridgman-5C7GfCeVMHo@public.gmane.org>,
	John Hubbard <jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Mark Hairgrove
	<mhairgrove-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Cameron Buschardt
	<cabuschardt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"peterz-hDdKplPs4pWWVfeAwA7xHQ@public.gmane.org"
	<peterz-hDdKplPs4pWWVfeAwA7xHQ@public.gmane.org>,
	Duncan Poole <dpoole-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"Cornwall, Jay" <Jay.Cornwall-5C7GfCeVMHo@public.gmane.org>,
	"Lewycky, Andrew" <Andrew.Lewycky-5C7GfCeVMHo@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.
Date: Tue, 1 Jul 2014 23:06:20 +0200	[thread overview]
Message-ID: <20140701210620.GL26537@8bytes.org> (raw)
In-Reply-To: <20140701193343.GB3322-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, Jul 01, 2014 at 03:33:44PM -0400, Jerome Glisse wrote:
> On Tue, Jul 01, 2014 at 01:00:18PM +0200, Joerg Roedel wrote:
> > No, its not in this case. The file descriptor is used to connect a
> > process address space with a device context. Thus without the mappings
> > the file-descriptor is useless and the mappings should stay in-tact
> > until the fd is closed.
> > 
> > It would be a very bad semantic for userspace if a fd that is passed on
> > fails on the other side because the sending process died.
> 
> Consider use case where there is no file associated with the mmu_notifier
> ie there is no device file descriptor that could hold and take care of
> mmu_notifier destruction and cleanup. We need this call chain for this
> case.

Example of such a use-case where no fd will be associated?

Anyway, even without an fd, there will always be something that sets the
mm->device binding up (calling mmu_notifier_register) and tears it down
in the end (calling mmu_notifier_unregister). And this will be the
places where any resources left from the .release call-back can be
cleaned up.


	Joerg

  parent reply	other threads:[~2014-07-01 21:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28  2:00 mm preparatory patches for HMM and IOMMUv2 Jérôme Glisse
2014-06-28  2:00 ` [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler Jérôme Glisse
2014-06-30  3:49   ` John Hubbard
2014-06-30 15:07     ` Jerome Glisse
2014-06-30 14:41   ` Gabbay, Oded
2014-06-30 15:06     ` Jerome Glisse
     [not found]     ` <019CCE693E457142B37B791721487FD91806B836-0nO7ALo/ziwxlywnonMhLEEOCMrvLtNR@public.gmane.org>
2014-06-30 15:40       ` Joerg Roedel
2014-06-30 16:06         ` Jerome Glisse
2014-06-30 18:16           ` Joerg Roedel
2014-06-30 18:35             ` Jerome Glisse
2014-06-30 18:57               ` Lewycky, Andrew
2014-07-01  9:41                 ` Joerg Roedel
     [not found]               ` <20140630183556.GB3280-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01  9:15                 ` Joerg Roedel
2014-07-01  9:29                   ` Gabbay, Oded
     [not found]                     ` <019CCE693E457142B37B791721487FD91806DD8B-0nO7ALo/ziwxlywnonMhLEEOCMrvLtNR@public.gmane.org>
2014-07-01 11:00                       ` Joerg Roedel
2014-07-01 19:33                         ` Jerome Glisse
     [not found]                           ` <20140701193343.GB3322-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01 21:06                             ` Joerg Roedel [this message]
2014-07-01 21:32                               ` Jerome Glisse
2014-07-03 18:30                                 ` Jerome Glisse
     [not found]                                   ` <20140703183024.GA3306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-03 23:15                                     ` Joerg Roedel
2014-07-04  0:03                                       ` Jerome Glisse
2014-07-06 19:25                                       ` Gabbay, Oded
2014-07-07 10:11                                         ` joro
2014-07-07 10:36                                           ` Oded Gabbay
2014-07-07 10:43                                           ` Oded Gabbay
     [not found]                                             ` <1404729783.31606.1.camel-OrheeFI7RUaGvNAqNQFwiPZ4XP/Yx64J@public.gmane.org>
2014-07-08  8:00                                               ` joro-zLv9SwRftAIdnm+yROfE0A
2014-07-08 17:03                                                 ` Jerome Glisse
2015-10-11 19:03                                                   ` David Woodhouse
2015-10-12 17:41                                                     ` Jerome Glisse
2015-11-20 15:45                                                     ` David Woodhouse
2014-06-30 15:37   ` Joerg Roedel
2014-06-28  2:00 ` [PATCH 2/6] mm: differentiate unmap for vmscan from other unmap Jérôme Glisse
2014-06-30  3:58   ` John Hubbard
2014-06-30 15:58     ` Jerome Glisse
2014-06-28  2:00 ` [PATCH 3/6] mmu_notifier: add event information to address invalidation v2 Jérôme Glisse
2014-06-30  5:22   ` John Hubbard
2014-06-30 15:57     ` Jerome Glisse
2014-07-01  1:57   ` Linus Torvalds
2014-06-28  2:00 ` [PATCH 4/6] mmu_notifier: pass through vma to invalidate_range and invalidate_page Jérôme Glisse
2014-06-30  3:29   ` John Hubbard
2014-06-30 16:00     ` Jerome Glisse
2014-07-01  2:04   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140701210620.GL26537@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=Andrew.Lewycky-5C7GfCeVMHo@public.gmane.org \
    --cc=Jay.Cornwall-5C7GfCeVMHo@public.gmane.org \
    --cc=John.Bridgman-5C7GfCeVMHo@public.gmane.org \
    --cc=Oded.Gabbay-5C7GfCeVMHo@public.gmane.org \
    --cc=SCheung-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=cabuschardt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=dpoole-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=j.glisse-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jakumar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ldunning-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mgorman-l3A5Bk7waGM@public.gmane.org \
    --cc=mhairgrove-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=peterz-hDdKplPs4pWWVfeAwA7xHQ@public.gmane.org \
    --cc=riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=sgutti-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).