linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	kbuild-all@01.org
Subject: Re: [mmotm:master 289/396] undefined reference to `crypto_alloc_shash'
Date: Thu, 3 Jul 2014 08:34:54 -0400	[thread overview]
Message-ID: <20140703123454.GB21156@redhat.com> (raw)
In-Reply-To: <53b49bda.Alc8D1c/m4kIm3gZ%fengguang.wu@intel.com>

On Thu, Jul 03, 2014 at 07:55:06AM +0800, kbuild test robot wrote:
> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   82b56f797fa200a5e9feac3a93cb6496909b9670
> commit: 025d75374c9c08274f60da5802381a8ef7490388 [289/396] kexec: load and relocate purgatory at kernel load time
> config: make ARCH=s390 allnoconfig
> 
> All error/warnings:
> 
>    kernel/built-in.o: In function `sys_kexec_file_load':
>    (.text+0x32314): undefined reference to `crypto_shash_final'
>    kernel/built-in.o: In function `sys_kexec_file_load':
>    (.text+0x32328): undefined reference to `crypto_shash_update'
>    kernel/built-in.o: In function `sys_kexec_file_load':
> >> (.text+0x32338): undefined reference to `crypto_alloc_shash'

Hi,

Now generic kexec implementation requires CRYPTO and CRYPTI_SHA256. Hence
I select these in arch/x86/Kconfig.

config KEXEC
        bool "kexec system call"
        select BUILD_BIN2C
        select CRYPTO
        select CRYPTO_SHA256

But I realize that I did not do it for other arches which have KEXEC
defined. And that will lead to failure on other arches.

I will write a patch now and create this additional dependency in
all other arch Kconfig files which support KEXEC.

Thanks
Vivek

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-07-03 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 23:55 [mmotm:master 289/396] undefined reference to `crypto_alloc_shash' kbuild test robot
2014-07-03 12:34 ` Vivek Goyal [this message]
2014-07-03 14:24 ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140703123454.GB21156@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).