* [mmotm:master 298/396] kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash'
@ 2014-07-03 5:56 kbuild test robot
2014-07-03 6:13 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2014-07-03 5:56 UTC (permalink / raw)
To: Joe Perches
Cc: Linux Memory Management List, Andrew Morton, Johannes Weiner,
kbuild-all
Hi Joe,
It's probably a bug fix that unveils the link errors.
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 82b56f797fa200a5e9feac3a93cb6496909b9670
commit: f192fb3c695b607044d4476c822783a8ae10ce75 [298/396] sysctl-remove-now-unused-typedef-ctl_table-fix
config: make ARCH=arm prima2_defconfig
All error/warnings:
kernel/built-in.o: In function `kexec_calculate_store_digests':
>> kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash'
>> kernel/kexec.c:2223: undefined reference to `crypto_shash_update'
>> kernel/kexec.c:2238: undefined reference to `crypto_shash_update'
>> kernel/kexec.c:2253: undefined reference to `crypto_shash_final'
vim +2181 kernel/kexec.c
025d7537 Vivek Goyal 2014-07-02 2175 struct kexec_sha_region *sha_regions;
025d7537 Vivek Goyal 2014-07-02 2176 struct purgatory_info *pi = &image->purgatory_info;
025d7537 Vivek Goyal 2014-07-02 2177
025d7537 Vivek Goyal 2014-07-02 2178 zero_buf = __va(page_to_pfn(ZERO_PAGE(0)) << PAGE_SHIFT);
025d7537 Vivek Goyal 2014-07-02 2179 zero_buf_sz = PAGE_SIZE;
025d7537 Vivek Goyal 2014-07-02 2180
025d7537 Vivek Goyal 2014-07-02 @2181 tfm = crypto_alloc_shash("sha256", 0, 0);
025d7537 Vivek Goyal 2014-07-02 2182 if (IS_ERR(tfm)) {
025d7537 Vivek Goyal 2014-07-02 2183 ret = PTR_ERR(tfm);
025d7537 Vivek Goyal 2014-07-02 2184 goto out;
025d7537 Vivek Goyal 2014-07-02 2185 }
025d7537 Vivek Goyal 2014-07-02 2186
025d7537 Vivek Goyal 2014-07-02 2187 desc_size = crypto_shash_descsize(tfm) + sizeof(*desc);
025d7537 Vivek Goyal 2014-07-02 2188 desc = kzalloc(desc_size, GFP_KERNEL);
025d7537 Vivek Goyal 2014-07-02 2189 if (!desc) {
025d7537 Vivek Goyal 2014-07-02 2190 ret = -ENOMEM;
025d7537 Vivek Goyal 2014-07-02 2191 goto out_free_tfm;
025d7537 Vivek Goyal 2014-07-02 2192 }
025d7537 Vivek Goyal 2014-07-02 2193
025d7537 Vivek Goyal 2014-07-02 2194 sha_region_sz = KEXEC_SEGMENT_MAX * sizeof(struct kexec_sha_region);
025d7537 Vivek Goyal 2014-07-02 2195 sha_regions = vzalloc(sha_region_sz);
025d7537 Vivek Goyal 2014-07-02 2196 if (!sha_regions)
025d7537 Vivek Goyal 2014-07-02 2197 goto out_free_desc;
025d7537 Vivek Goyal 2014-07-02 2198
025d7537 Vivek Goyal 2014-07-02 2199 desc->tfm = tfm;
025d7537 Vivek Goyal 2014-07-02 2200 desc->flags = 0;
025d7537 Vivek Goyal 2014-07-02 2201
025d7537 Vivek Goyal 2014-07-02 2202 ret = crypto_shash_init(desc);
025d7537 Vivek Goyal 2014-07-02 2203 if (ret < 0)
025d7537 Vivek Goyal 2014-07-02 2204 goto out_free_sha_regions;
025d7537 Vivek Goyal 2014-07-02 2205
025d7537 Vivek Goyal 2014-07-02 2206 digest = kzalloc(SHA256_DIGEST_SIZE, GFP_KERNEL);
025d7537 Vivek Goyal 2014-07-02 2207 if (!digest) {
025d7537 Vivek Goyal 2014-07-02 2208 ret = -ENOMEM;
025d7537 Vivek Goyal 2014-07-02 2209 goto out_free_sha_regions;
025d7537 Vivek Goyal 2014-07-02 2210 }
025d7537 Vivek Goyal 2014-07-02 2211
025d7537 Vivek Goyal 2014-07-02 2212 for (j = i = 0; i < image->nr_segments; i++) {
025d7537 Vivek Goyal 2014-07-02 2213 struct kexec_segment *ksegment;
025d7537 Vivek Goyal 2014-07-02 2214
025d7537 Vivek Goyal 2014-07-02 2215 ksegment = &image->segment[i];
025d7537 Vivek Goyal 2014-07-02 2216 /*
025d7537 Vivek Goyal 2014-07-02 2217 * Skip purgatory as it will be modified once we put digest
025d7537 Vivek Goyal 2014-07-02 2218 * info in purgatory.
025d7537 Vivek Goyal 2014-07-02 2219 */
025d7537 Vivek Goyal 2014-07-02 2220 if (ksegment->kbuf == pi->purgatory_buf)
025d7537 Vivek Goyal 2014-07-02 2221 continue;
025d7537 Vivek Goyal 2014-07-02 2222
025d7537 Vivek Goyal 2014-07-02 @2223 ret = crypto_shash_update(desc, ksegment->kbuf,
025d7537 Vivek Goyal 2014-07-02 2224 ksegment->bufsz);
025d7537 Vivek Goyal 2014-07-02 2225 if (ret)
025d7537 Vivek Goyal 2014-07-02 2226 break;
025d7537 Vivek Goyal 2014-07-02 2227
025d7537 Vivek Goyal 2014-07-02 2228 /*
025d7537 Vivek Goyal 2014-07-02 2229 * Assume rest of the buffer is filled with zero and
025d7537 Vivek Goyal 2014-07-02 2230 * update digest accordingly.
025d7537 Vivek Goyal 2014-07-02 2231 */
025d7537 Vivek Goyal 2014-07-02 2232 nullsz = ksegment->memsz - ksegment->bufsz;
025d7537 Vivek Goyal 2014-07-02 2233 while (nullsz) {
025d7537 Vivek Goyal 2014-07-02 2234 unsigned long bytes = nullsz;
025d7537 Vivek Goyal 2014-07-02 2235
025d7537 Vivek Goyal 2014-07-02 2236 if (bytes > zero_buf_sz)
025d7537 Vivek Goyal 2014-07-02 2237 bytes = zero_buf_sz;
025d7537 Vivek Goyal 2014-07-02 @2238 ret = crypto_shash_update(desc, zero_buf, bytes);
025d7537 Vivek Goyal 2014-07-02 2239 if (ret)
025d7537 Vivek Goyal 2014-07-02 2240 break;
025d7537 Vivek Goyal 2014-07-02 2241 nullsz -= bytes;
025d7537 Vivek Goyal 2014-07-02 2242 }
025d7537 Vivek Goyal 2014-07-02 2243
025d7537 Vivek Goyal 2014-07-02 2244 if (ret)
025d7537 Vivek Goyal 2014-07-02 2245 break;
025d7537 Vivek Goyal 2014-07-02 2246
025d7537 Vivek Goyal 2014-07-02 2247 sha_regions[j].start = ksegment->mem;
025d7537 Vivek Goyal 2014-07-02 2248 sha_regions[j].len = ksegment->memsz;
025d7537 Vivek Goyal 2014-07-02 2249 j++;
025d7537 Vivek Goyal 2014-07-02 2250 }
025d7537 Vivek Goyal 2014-07-02 2251
025d7537 Vivek Goyal 2014-07-02 2252 if (!ret) {
025d7537 Vivek Goyal 2014-07-02 @2253 ret = crypto_shash_final(desc, digest);
025d7537 Vivek Goyal 2014-07-02 2254 if (ret)
025d7537 Vivek Goyal 2014-07-02 2255 goto out_free_digest;
025d7537 Vivek Goyal 2014-07-02 2256 ret = kexec_purgatory_get_set_symbol(image, "sha_regions",
:::::: The code at line 2181 was first introduced by commit
:::::: 025d75374c9c08274f60da5802381a8ef7490388 kexec: load and relocate purgatory at kernel load time
:::::: TO: Vivek Goyal <vgoyal@redhat.com>
:::::: CC: Johannes Weiner <hannes@cmpxchg.org>
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [mmotm:master 298/396] kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash'
2014-07-03 5:56 [mmotm:master 298/396] kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash' kbuild test robot
@ 2014-07-03 6:13 ` Joe Perches
2014-07-03 14:29 ` Vivek Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2014-07-03 6:13 UTC (permalink / raw)
To: kbuild test robot, Vivek Goyal
Cc: Linux Memory Management List, Andrew Morton, Johannes Weiner,
kbuild-all
On Thu, 2014-07-03 at 13:56 +0800, kbuild test robot wrote:
> Hi Joe,
Hi Fengguang.
> It's probably a bug fix that unveils the link errors.
I don't understand how the typedef removal matters here.
Is this some sort of bisect false positive?
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 82b56f797fa200a5e9feac3a93cb6496909b9670
> commit: f192fb3c695b607044d4476c822783a8ae10ce75 [298/396] sysctl-remove-now-unused-typedef-ctl_table-fix
> config: make ARCH=arm prima2_defconfig
>
> All error/warnings:
>
> kernel/built-in.o: In function `kexec_calculate_store_digests':
> >> kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash'
> >> kernel/kexec.c:2223: undefined reference to `crypto_shash_update'
> >> kernel/kexec.c:2238: undefined reference to `crypto_shash_update'
> >> kernel/kexec.c:2253: undefined reference to `crypto_shash_final'
>
> vim +2181 kernel/kexec.c
>
> 025d7537 Vivek Goyal 2014-07-02 2175 struct kexec_sha_region *sha_regions;
> 025d7537 Vivek Goyal 2014-07-02 2176 struct purgatory_info *pi = &image->purgatory_info;
> 025d7537 Vivek Goyal 2014-07-02 2177
> 025d7537 Vivek Goyal 2014-07-02 2178 zero_buf = __va(page_to_pfn(ZERO_PAGE(0)) << PAGE_SHIFT);
> 025d7537 Vivek Goyal 2014-07-02 2179 zero_buf_sz = PAGE_SIZE;
> 025d7537 Vivek Goyal 2014-07-02 2180
> 025d7537 Vivek Goyal 2014-07-02 @2181 tfm = crypto_alloc_shash("sha256", 0, 0);
> 025d7537 Vivek Goyal 2014-07-02 2182 if (IS_ERR(tfm)) {
> 025d7537 Vivek Goyal 2014-07-02 2183 ret = PTR_ERR(tfm);
> 025d7537 Vivek Goyal 2014-07-02 2184 goto out;
> 025d7537 Vivek Goyal 2014-07-02 2185 }
> 025d7537 Vivek Goyal 2014-07-02 2186
> 025d7537 Vivek Goyal 2014-07-02 2187 desc_size = crypto_shash_descsize(tfm) + sizeof(*desc);
> 025d7537 Vivek Goyal 2014-07-02 2188 desc = kzalloc(desc_size, GFP_KERNEL);
> 025d7537 Vivek Goyal 2014-07-02 2189 if (!desc) {
> 025d7537 Vivek Goyal 2014-07-02 2190 ret = -ENOMEM;
> 025d7537 Vivek Goyal 2014-07-02 2191 goto out_free_tfm;
> 025d7537 Vivek Goyal 2014-07-02 2192 }
> 025d7537 Vivek Goyal 2014-07-02 2193
> 025d7537 Vivek Goyal 2014-07-02 2194 sha_region_sz = KEXEC_SEGMENT_MAX * sizeof(struct kexec_sha_region);
> 025d7537 Vivek Goyal 2014-07-02 2195 sha_regions = vzalloc(sha_region_sz);
> 025d7537 Vivek Goyal 2014-07-02 2196 if (!sha_regions)
> 025d7537 Vivek Goyal 2014-07-02 2197 goto out_free_desc;
> 025d7537 Vivek Goyal 2014-07-02 2198
> 025d7537 Vivek Goyal 2014-07-02 2199 desc->tfm = tfm;
> 025d7537 Vivek Goyal 2014-07-02 2200 desc->flags = 0;
> 025d7537 Vivek Goyal 2014-07-02 2201
> 025d7537 Vivek Goyal 2014-07-02 2202 ret = crypto_shash_init(desc);
> 025d7537 Vivek Goyal 2014-07-02 2203 if (ret < 0)
> 025d7537 Vivek Goyal 2014-07-02 2204 goto out_free_sha_regions;
> 025d7537 Vivek Goyal 2014-07-02 2205
> 025d7537 Vivek Goyal 2014-07-02 2206 digest = kzalloc(SHA256_DIGEST_SIZE, GFP_KERNEL);
> 025d7537 Vivek Goyal 2014-07-02 2207 if (!digest) {
> 025d7537 Vivek Goyal 2014-07-02 2208 ret = -ENOMEM;
> 025d7537 Vivek Goyal 2014-07-02 2209 goto out_free_sha_regions;
> 025d7537 Vivek Goyal 2014-07-02 2210 }
> 025d7537 Vivek Goyal 2014-07-02 2211
> 025d7537 Vivek Goyal 2014-07-02 2212 for (j = i = 0; i < image->nr_segments; i++) {
> 025d7537 Vivek Goyal 2014-07-02 2213 struct kexec_segment *ksegment;
> 025d7537 Vivek Goyal 2014-07-02 2214
> 025d7537 Vivek Goyal 2014-07-02 2215 ksegment = &image->segment[i];
> 025d7537 Vivek Goyal 2014-07-02 2216 /*
> 025d7537 Vivek Goyal 2014-07-02 2217 * Skip purgatory as it will be modified once we put digest
> 025d7537 Vivek Goyal 2014-07-02 2218 * info in purgatory.
> 025d7537 Vivek Goyal 2014-07-02 2219 */
> 025d7537 Vivek Goyal 2014-07-02 2220 if (ksegment->kbuf == pi->purgatory_buf)
> 025d7537 Vivek Goyal 2014-07-02 2221 continue;
> 025d7537 Vivek Goyal 2014-07-02 2222
> 025d7537 Vivek Goyal 2014-07-02 @2223 ret = crypto_shash_update(desc, ksegment->kbuf,
> 025d7537 Vivek Goyal 2014-07-02 2224 ksegment->bufsz);
> 025d7537 Vivek Goyal 2014-07-02 2225 if (ret)
> 025d7537 Vivek Goyal 2014-07-02 2226 break;
> 025d7537 Vivek Goyal 2014-07-02 2227
> 025d7537 Vivek Goyal 2014-07-02 2228 /*
> 025d7537 Vivek Goyal 2014-07-02 2229 * Assume rest of the buffer is filled with zero and
> 025d7537 Vivek Goyal 2014-07-02 2230 * update digest accordingly.
> 025d7537 Vivek Goyal 2014-07-02 2231 */
> 025d7537 Vivek Goyal 2014-07-02 2232 nullsz = ksegment->memsz - ksegment->bufsz;
> 025d7537 Vivek Goyal 2014-07-02 2233 while (nullsz) {
> 025d7537 Vivek Goyal 2014-07-02 2234 unsigned long bytes = nullsz;
> 025d7537 Vivek Goyal 2014-07-02 2235
> 025d7537 Vivek Goyal 2014-07-02 2236 if (bytes > zero_buf_sz)
> 025d7537 Vivek Goyal 2014-07-02 2237 bytes = zero_buf_sz;
> 025d7537 Vivek Goyal 2014-07-02 @2238 ret = crypto_shash_update(desc, zero_buf, bytes);
> 025d7537 Vivek Goyal 2014-07-02 2239 if (ret)
> 025d7537 Vivek Goyal 2014-07-02 2240 break;
> 025d7537 Vivek Goyal 2014-07-02 2241 nullsz -= bytes;
> 025d7537 Vivek Goyal 2014-07-02 2242 }
> 025d7537 Vivek Goyal 2014-07-02 2243
> 025d7537 Vivek Goyal 2014-07-02 2244 if (ret)
> 025d7537 Vivek Goyal 2014-07-02 2245 break;
> 025d7537 Vivek Goyal 2014-07-02 2246
> 025d7537 Vivek Goyal 2014-07-02 2247 sha_regions[j].start = ksegment->mem;
> 025d7537 Vivek Goyal 2014-07-02 2248 sha_regions[j].len = ksegment->memsz;
> 025d7537 Vivek Goyal 2014-07-02 2249 j++;
> 025d7537 Vivek Goyal 2014-07-02 2250 }
> 025d7537 Vivek Goyal 2014-07-02 2251
> 025d7537 Vivek Goyal 2014-07-02 2252 if (!ret) {
> 025d7537 Vivek Goyal 2014-07-02 @2253 ret = crypto_shash_final(desc, digest);
> 025d7537 Vivek Goyal 2014-07-02 2254 if (ret)
> 025d7537 Vivek Goyal 2014-07-02 2255 goto out_free_digest;
> 025d7537 Vivek Goyal 2014-07-02 2256 ret = kexec_purgatory_get_set_symbol(image, "sha_regions",
>
> :::::: The code at line 2181 was first introduced by commit
> :::::: 025d75374c9c08274f60da5802381a8ef7490388 kexec: load and relocate purgatory at kernel load time
>
> :::::: TO: Vivek Goyal <vgoyal@redhat.com>
> :::::: CC: Johannes Weiner <hannes@cmpxchg.org>
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [mmotm:master 298/396] kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash'
2014-07-03 6:13 ` Joe Perches
@ 2014-07-03 14:29 ` Vivek Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Vivek Goyal @ 2014-07-03 14:29 UTC (permalink / raw)
To: Joe Perches
Cc: kbuild test robot, Linux Memory Management List, Andrew Morton,
Johannes Weiner, kbuild-all
On Wed, Jul 02, 2014 at 11:13:38PM -0700, Joe Perches wrote:
> On Thu, 2014-07-03 at 13:56 +0800, kbuild test robot wrote:
> > Hi Joe,
>
> Hi Fengguang.
>
> > It's probably a bug fix that unveils the link errors.
>
> I don't understand how the typedef removal matters here.
> Is this some sort of bisect false positive?
>
> > tree: git://git.cmpxchg.org/linux-mmotm.git master
> > head: 82b56f797fa200a5e9feac3a93cb6496909b9670
> > commit: f192fb3c695b607044d4476c822783a8ae10ce75 [298/396] sysctl-remove-now-unused-typedef-ctl_table-fix
> > config: make ARCH=arm prima2_defconfig
> >
> > All error/warnings:
> >
> > kernel/built-in.o: In function `kexec_calculate_store_digests':
> > >> kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash'
> > >> kernel/kexec.c:2223: undefined reference to `crypto_shash_update'
> > >> kernel/kexec.c:2238: undefined reference to `crypto_shash_update'
> > >> kernel/kexec.c:2253: undefined reference to `crypto_shash_final'
I think these errors are happening because of kexe changes. Now kexec
requires CRYPTO and CRYPTO_SHA256. I did the change for x86 but not
for other arches supporting kexec. Just now I sent a patch to fix
these errors.
Inlining same patch here again for reference. I think this patch
should fix it.
Subject: kexec: set CRYPTO=y and CRYPTO_SHA256=y for all arch supporting kexec
Generic kexec implementation now makes use of crypto API to calculate the
sha256 digest of loaded kernel segments (for new syscall kexec_file_load()).
That means one need to enforce that CRYPTO and CRYPTO_SHA256 are built in
for kexec to compile and for new syscall to work.
I created this dependency for x86 but forgot to do for other arches
supporting kexec. And ran into compilation failure reports from kbuild
test robot.
kernel/built-in.o: In function `sys_kexec_file_load':
(.text+0x32314): undefined reference to `crypto_shash_final'
kernel/built-in.o: In function `sys_kexec_file_load':
(.text+0x32328): undefined reference to `crypto_shash_update'
kernel/built-in.o: In function `sys_kexec_file_load':
>> (.text+0x32338): undefined reference to `crypto_alloc_shash'
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
arch/arm/Kconfig | 2 ++
arch/ia64/Kconfig | 2 ++
arch/m68k/Kconfig | 2 ++
arch/mips/Kconfig | 2 ++
arch/powerpc/Kconfig | 2 ++
arch/s390/Kconfig | 2 ++
arch/sh/Kconfig | 2 ++
arch/tile/Kconfig | 2 ++
8 files changed, 16 insertions(+)
Index: linux-2.6/arch/s390/Kconfig
===================================================================
--- linux-2.6.orig/arch/s390/Kconfig 2014-07-03 09:32:29.866684834 -0400
+++ linux-2.6/arch/s390/Kconfig 2014-07-03 09:41:40.918646043 -0400
@@ -48,6 +48,8 @@ config ARCH_SUPPORTS_DEBUG_PAGEALLOC
config KEXEC
def_bool y
+ select CRYPTO
+ select CRYPTO_SHA256
config AUDIT_ARCH
def_bool y
Index: linux-2.6/arch/powerpc/Kconfig
===================================================================
--- linux-2.6.orig/arch/powerpc/Kconfig 2014-07-03 09:32:29.866684834 -0400
+++ linux-2.6/arch/powerpc/Kconfig 2014-07-03 09:41:40.918646043 -0400
@@ -397,6 +397,8 @@ config PPC64_SUPPORTS_MEMORY_FAILURE
config KEXEC
bool "kexec system call"
depends on (PPC_BOOK3S || FSL_BOOKE || (44x && !SMP))
+ select CRYPTO
+ select CRYPTO_SHA256
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Index: linux-2.6/arch/arm/Kconfig
===================================================================
--- linux-2.6.orig/arch/arm/Kconfig 2014-07-03 09:32:29.866684834 -0400
+++ linux-2.6/arch/arm/Kconfig 2014-07-03 09:41:40.919646043 -0400
@@ -2050,6 +2050,8 @@ config XIP_PHYS_ADDR
config KEXEC
bool "Kexec system call (EXPERIMENTAL)"
depends on (!SMP || PM_SLEEP_SMP)
+ select CRYPTO
+ select CRYPTO_SHA256
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Index: linux-2.6/arch/m68k/Kconfig
===================================================================
--- linux-2.6.orig/arch/m68k/Kconfig 2014-07-03 09:32:29.866684834 -0400
+++ linux-2.6/arch/m68k/Kconfig 2014-07-03 09:41:40.919646043 -0400
@@ -91,6 +91,8 @@ config MMU_SUN3
config KEXEC
bool "kexec system call"
depends on M68KCLASSIC
+ select CRYPTO
+ select CRYPTO_SHA256
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Index: linux-2.6/arch/ia64/Kconfig
===================================================================
--- linux-2.6.orig/arch/ia64/Kconfig 2014-06-24 15:56:04.045803541 -0400
+++ linux-2.6/arch/ia64/Kconfig 2014-07-03 09:51:00.615606643 -0400
@@ -547,6 +547,8 @@ source "drivers/sn/Kconfig"
config KEXEC
bool "kexec system call"
depends on !IA64_HP_SIM && (!SMP || HOTPLUG_CPU)
+ select CRYPTO
+ select CRYPTO_SHA256
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Index: linux-2.6/arch/mips/Kconfig
===================================================================
--- linux-2.6.orig/arch/mips/Kconfig 2014-06-30 16:17:09.974221907 -0400
+++ linux-2.6/arch/mips/Kconfig 2014-07-03 09:54:49.371590540 -0400
@@ -2392,6 +2392,8 @@ source "kernel/Kconfig.preempt"
config KEXEC
bool "Kexec system call"
+ select CRYPTO
+ select CRYPTO_SHA256
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Index: linux-2.6/arch/sh/Kconfig
===================================================================
--- linux-2.6.orig/arch/sh/Kconfig 2014-06-24 15:56:04.906803481 -0400
+++ linux-2.6/arch/sh/Kconfig 2014-07-03 09:59:31.849570655 -0400
@@ -596,6 +596,8 @@ source kernel/Kconfig.hz
config KEXEC
bool "kexec system call (EXPERIMENTAL)"
depends on SUPERH32 && MMU
+ select CRYPTO
+ select CRYPTO_SHA256
help
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Index: linux-2.6/arch/tile/Kconfig
===================================================================
--- linux-2.6.orig/arch/tile/Kconfig 2014-06-24 15:56:05.086803468 -0400
+++ linux-2.6/arch/tile/Kconfig 2014-07-03 10:02:45.223557043 -0400
@@ -192,6 +192,8 @@ source "kernel/Kconfig.hz"
config KEXEC
bool "kexec system call"
+ select CRYPTO
+ select CRYPTO_SHA256
---help---
kexec is a system call that implements the ability to shutdown your
current kernel, and to start another kernel. It is like a reboot
Thanks
Vivek
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-03 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-03 5:56 [mmotm:master 298/396] kernel/kexec.c:2181: undefined reference to `crypto_alloc_shash' kbuild test robot
2014-07-03 6:13 ` Joe Perches
2014-07-03 14:29 ` Vivek Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).