From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by kanga.kvack.org (Postfix) with ESMTP id 739D96B0037 for ; Mon, 7 Jul 2014 05:23:03 -0400 (EDT) Received: by mail-wg0-f51.google.com with SMTP id x12so3982414wgg.22 for ; Mon, 07 Jul 2014 02:22:58 -0700 (PDT) Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by mx.google.com with ESMTPS id cu10si40293871wib.82.2014.07.07.02.22.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 07 Jul 2014 02:22:58 -0700 (PDT) Received: by mail-wg0-f46.google.com with SMTP id l18so680173wgh.5 for ; Mon, 07 Jul 2014 02:22:58 -0700 (PDT) Date: Mon, 7 Jul 2014 10:22:48 +0100 From: Steve Capper Subject: Re: [PATCH v10 6/7] ARM: add pmd_[dirty|mkclean] for THP Message-ID: <20140707092247.GA15168@linaro.org> References: <1404694438-10272-1-git-send-email-minchan@kernel.org> <1404694438-10272-7-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404694438-10272-7-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Catalin Marinas , Will Deacon , Russell King , linux-arm-kernel@lists.infradead.org On Mon, Jul 07, 2014 at 09:53:57AM +0900, Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Steve Capper > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Minchan Kim > --- > arch/arm64/include/asm/pgtable.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 579702086488..f3ec01cef04f 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -240,10 +240,12 @@ static inline pmd_t pte_pmd(pte_t pte) > #endif > > #define pmd_young(pmd) pte_young(pmd_pte(pmd)) > +#define pmd_dirty(pmd) pte_dirty(pmd_pte(pmd)) > #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) > #define pmd_mksplitting(pmd) pte_pmd(pte_mkspecial(pmd_pte(pmd))) > #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) > #define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) > +#define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) > #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) > #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) > #define pmd_mknotpresent(pmd) (__pmd(pmd_val(pmd) & ~PMD_TYPE_MASK)) > -- > 2.0.0 > Hi Minchan, This looks good to me too. As Will said this applies to arm64, we will also need a version for: arch/arm/include/asm/pgtable-3level.h. Is there a testcase we can run to check that this patch set is working well for arm/arm64? Cheers, -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org