From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: WANG Chao <chaowang@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Chris Metcalf <cmetcalf@tilera.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/vmalloc.c: clean up map_vm_area third argument
Date: Wed, 9 Jul 2014 21:37:38 -0700 [thread overview]
Message-ID: <20140710043738.GA13532@kroah.com> (raw)
In-Reply-To: <1404966367-7599-1-git-send-email-chaowang@redhat.com>
On Thu, Jul 10, 2014 at 12:26:07PM +0800, WANG Chao wrote:
> Currently map_vm_area() takes (struct page *** pages) as third argument,
> and after mapping, it moves (*pages) to point to (*pages + nr_mappped_pages).
>
> It looks like this kind of increment is useless to its caller these
> days. The callers don't care about the increments and actually they're
> trying to avoid this by passing another copy to map_vm_area().
>
> The caller can always guarantee all the pages can be mapped into
> vm_area as specified in first argument and the caller only cares about
> whether map_vm_area() fails or not.
>
> This patch cleans up the pointer movement in map_vm_area() and updates
> its callers accordingly.
>
> v2: Fix arch/tile/kernel/module.c::module_alloc().
>
> Signed-off-by: WANG Chao <chaowang@redhat.com>
> ---
> arch/tile/kernel/module.c | 2 +-
> drivers/lguest/core.c | 7 ++-----
> drivers/staging/android/binder.c | 4 +---
> include/linux/vmalloc.h | 2 +-
> mm/vmalloc.c | 14 +++++---------
> mm/zsmalloc.c | 2 +-
> 6 files changed, 11 insertions(+), 20 deletions(-)
Staging code:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-07-10 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 8:32 [PATCH] mm/vmalloc.c: clean up map_vm_area third argument WANG Chao
2014-07-10 4:26 ` [PATCH v2] " WANG Chao
2014-07-10 4:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710043738.GA13532@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=chaowang@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=rusty@rustcorp.com.au \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).