From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by kanga.kvack.org (Postfix) with ESMTP id C16AE6B0035 for ; Fri, 18 Jul 2014 04:49:29 -0400 (EDT) Received: by mail-pd0-f174.google.com with SMTP id fp1so4635733pdb.5 for ; Fri, 18 Jul 2014 01:49:29 -0700 (PDT) Received: from cam-admin0.cambridge.arm.com (cam-admin0.cambridge.arm.com. [217.140.96.50]) by mx.google.com with ESMTP id v3si2558152pdp.514.2014.07.18.01.49.28 for ; Fri, 18 Jul 2014 01:49:28 -0700 (PDT) Date: Fri, 18 Jul 2014 09:48:47 +0100 From: Will Deacon Subject: Re: [PATCH v13 6/8] arm: add pmd_[dirty|mkclean] for THP Message-ID: <20140718084847.GC9548@arm.com> References: <1405666386-15095-1-git-send-email-minchan@kernel.org> <1405666386-15095-7-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405666386-15095-7-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Michael Kerrisk , Linux API , Hugh Dickins , Johannes Weiner , Rik van Riel , KOSAKI Motohiro , Mel Gorman , Jason Evans , Zhang Yanfei , "Kirill A. Shutemov" , Catalin Marinas , Steve Capper , Russell King , "linux-arm-kernel@lists.infradead.org" On Fri, Jul 18, 2014 at 07:53:04AM +0100, Minchan Kim wrote: > MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent > overwrite of the contents since MADV_FREE syscall is called for > THP page. > > This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE > support. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Steve Capper > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Minchan Kim > --- > arch/arm/include/asm/pgtable-3level.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > index 85c60adc8b60..830f84f2d277 100644 > --- a/arch/arm/include/asm/pgtable-3level.h > +++ b/arch/arm/include/asm/pgtable-3level.h > @@ -220,6 +220,8 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) > #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) > #endif > > +#define pmd_dirty(pmd) (pmd_val(pmd) & PMD_SECT_DIRTY) > + > #define PMD_BIT_FUNC(fn,op) \ > static inline pmd_t pmd_##fn(pmd_t pmd) { pmd_val(pmd) op; return pmd; } > > @@ -228,6 +230,7 @@ PMD_BIT_FUNC(mkold, &= ~PMD_SECT_AF); > PMD_BIT_FUNC(mksplitting, |= PMD_SECT_SPLITTING); > PMD_BIT_FUNC(mkwrite, &= ~PMD_SECT_RDONLY); > PMD_BIT_FUNC(mkdirty, |= PMD_SECT_DIRTY); > +PMD_BIT_FUNC(mkclean, &= ~PMD_SECT_DIRTY); > PMD_BIT_FUNC(mkyoung, |= PMD_SECT_AF); > > #define pmd_mkhuge(pmd) (__pmd(pmd_val(pmd) & ~PMD_TABLE_BIT)) Looks fine to me, but again, it would be great if Steve can take a look too. Will -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org