linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] mm: Actually clear pmd_numa before invalidating
Date: Wed, 13 Aug 2014 13:12:41 -0700	[thread overview]
Message-ID: <20140813131241.3ced5ccaeec24fcd378a1ef6@linux-foundation.org> (raw)
In-Reply-To: <100D68C7BA14664A8938383216E40DE0407D0CA2@FMSMSX114.amr.corp.intel.com>

On Wed, 13 Aug 2014 20:04:02 +0000 "Wilcox, Matthew R" <matthew.r.wilcox@intel.com> wrote:

> The commit log for 67f87463d3 explains what the runtime effects should have been.

No it doesn't.  In fact the sentence "The existing caller of
pmdp_invalidate should handle it but it's an inconsistent state for a
PMD." makes me suspect there are no end-user visible effects.

I don't know why we chose to backport that one into -stable and I don't
know why we should backport this one either.

Greg (and others) will look at this changelog and wonder "why".  It
should tell them.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-08-13 20:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 15:28 [PATCH] mm: Actually clear pmd_numa before invalidating Matthew Wilcox
2014-08-13 15:56 ` Rik van Riel
2014-08-13 16:32 ` Mel Gorman
2014-08-13 19:59 ` Andrew Morton
2014-08-13 20:04   ` Wilcox, Matthew R
2014-08-13 20:12     ` Andrew Morton [this message]
2014-08-13 20:16       ` Wilcox, Matthew R
2014-08-13 20:23         ` Andrew Morton
2014-08-13 21:18           ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813131241.3ced5ccaeec24fcd378a1ef6@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew.r.wilcox@intel.com \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).