From: Tejun Heo <tj@kernel.org>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tang Chen <tangchen@cn.fujitsu.com>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"H. Peter Anvin" <hpa@zytor.com>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range()
Date: Sun, 17 Aug 2014 07:08:21 -0400 [thread overview]
Message-ID: <20140817110821.GM9305@htj.dyndns.org> (raw)
In-Reply-To: <53EF6C79.3000603@huawei.com>
Hello,
On Sat, Aug 16, 2014 at 10:36:41PM +0800, Xishi Qiu wrote:
> numa_clear_node_hotplug()? There is only numa_clear_kernel_node_hotplug().
Yeah, that one.
> If we don't clear hotpluggable flag in free_low_memory_core_early(), the
> memory which marked hotpluggable flag will not free to buddy allocator.
> Because __next_mem_range() will skip them.
>
> free_low_memory_core_early
> for_each_free_mem_range
> for_each_mem_range
> __next_mem_range
Ah, okay, so the patch fixes __next_mem_range() and thus makes
free_low_memory_core_early() to skip hotpluggable regions unlike
before. Please explain things like that in the changelog. Also,
what's its relationship with numa_clear_kernel_node_hotplug()? Do we
still need them? If so, what are the different roles that these two
separate places serve?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-08-17 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 13:31 [PATCH] mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range() Xishi Qiu
2014-08-16 13:04 ` Tejun Heo
2014-08-16 14:36 ` Xishi Qiu
2014-08-17 11:08 ` Tejun Heo [this message]
2014-08-18 1:13 ` tangchen
2014-08-18 3:18 ` Xishi Qiu
2014-08-18 13:13 ` Tejun Heo
2014-08-18 2:00 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140817110821.GM9305@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiuxishi@huawei.com \
--cc=rjw@sisk.pl \
--cc=tangchen@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).