From: Tejun Heo <tj@kernel.org>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: tangchen <tangchen@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>,
"H. Peter Anvin" <hpa@zytor.com>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range()
Date: Mon, 18 Aug 2014 09:13:01 -0400 [thread overview]
Message-ID: <20140818131301.GA16425@mtj.dyndns.org> (raw)
In-Reply-To: <53F17068.5000005@huawei.com>
Hello, Xishi, Tang.
On Mon, Aug 18, 2014 at 11:18:00AM +0800, Xishi Qiu wrote:
> If all the nodes are marked hotpluggable flag, alloc node data will fail.
> Because __next_mem_range_rev() will skip the hotpluggable memory regions.
> numa_register_memblks()
> setup_node_data()
> memblock_find_in_range_node()
> __memblock_find_range_top_down()
> for_each_mem_range_rev()
> __next_mem_range_rev()
I'm not sure clearing hotplug flag for all memory is the best approach
here. The problem is that there are places where we want to be
selectively ignoring the hotplug status and apparently we may want it
back later. Why not add an agument to memblock allocation / iteration
functions so that hotplug area can be skipped selectively?
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-08-18 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 13:31 [PATCH] mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range() Xishi Qiu
2014-08-16 13:04 ` Tejun Heo
2014-08-16 14:36 ` Xishi Qiu
2014-08-17 11:08 ` Tejun Heo
2014-08-18 1:13 ` tangchen
2014-08-18 3:18 ` Xishi Qiu
2014-08-18 13:13 ` Tejun Heo [this message]
2014-08-18 2:00 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818131301.GA16425@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiuxishi@huawei.com \
--cc=tangchen@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).