From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f52.google.com (mail-qa0-f52.google.com [209.85.216.52]) by kanga.kvack.org (Postfix) with ESMTP id CD64D6B0035 for ; Fri, 29 Aug 2014 17:26:13 -0400 (EDT) Received: by mail-qa0-f52.google.com with SMTP id f12so2652547qad.25 for ; Fri, 29 Aug 2014 14:26:13 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id y1si2013607qal.18.2014.08.29.14.26.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Aug 2014 14:26:13 -0700 (PDT) Date: Fri, 29 Aug 2014 17:26:04 -0400 From: Rafael Aquini Subject: Re: [PATCH 7/7] mm/balloon_compaction: general cleanup Message-ID: <20140829212604.GA20984@t510.redhat.com> References: <20140820150435.4194.28003.stgit@buzz> <20140820150509.4194.24336.stgit@buzz> <20140829140521.ca9b1dc87c8bc4b075f5b083@linux-foundation.org> <20140829210955.GB11878@t510.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140829210955.GB11878@t510.redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Konstantin Khlebnikov , linux-mm@kvack.org, Sasha Levin , Andrey Ryabinin , linux-kernel@vger.kernel.org On Fri, Aug 29, 2014 at 05:09:55PM -0400, Rafael Aquini wrote: > On Fri, Aug 29, 2014 at 02:05:21PM -0700, Andrew Morton wrote: > > On Wed, 20 Aug 2014 19:05:09 +0400 Konstantin Khlebnikov wrote: > > > > > * move special branch for balloon migraion into migrate_pages > > > * remove special mapping for balloon and its flag AS_BALLOON_MAP > > > * embed struct balloon_dev_info into struct virtio_balloon > > > * cleanup balloon_page_dequeue, kill balloon_page_free > > > > > > > grump. > > > > diff -puN include/linux/balloon_compaction.h~mm-balloon_compaction-general-cleanup-fix include/linux/balloon_compaction.h > > --- a/include/linux/balloon_compaction.h~mm-balloon_compaction-general-cleanup-fix > > +++ a/include/linux/balloon_compaction.h > > @@ -145,7 +145,7 @@ static inline void > > balloon_page_insert(struct balloon_dev_info *balloon, struct page *page) > > { > > __SetPageBalloon(page); > > - list_add(&page->lru, head); > > + list_add(&page->lru, &balloon->pages); > > } > > > > static inline void balloon_page_delete(struct page *page, bool isolated) > > > > > > This obviously wasn't tested with CONFIG_BALLOON_COMPACTION=n. Please > > complete the testing of this patchset and let us know the result? > > > Btw, I'll do a mea culpa here. Although this build failure was addressed by my extra-cleanup suggestion, I never made that statement clear at my original message. http://permalink.gmane.org/gmane.linux.kernel.mm/121788 Sorry, -- Rafael > That also reminds me why I suggested moving those as static inlines into mm.h, > instead of getting them hidden in mm/balloon_compaction.c > > Cheers, > -- Rafael -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org