From: Johannes Weiner <hannes@cmpxchg.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: clean up zone flags
Date: Tue, 2 Sep 2014 18:26:53 -0400 [thread overview]
Message-ID: <20140902222653.GA20186@cmpxchg.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1409021437160.28054@chino.kir.corp.google.com>
On Tue, Sep 02, 2014 at 02:42:14PM -0700, David Rientjes wrote:
> On Tue, 2 Sep 2014, Johannes Weiner wrote:
> > @@ -631,7 +631,7 @@ long wait_iff_congested(struct zone *zone, int sync, long timeout)
> > * of sleeping on the congestion queue
> > */
> > if (atomic_read(&nr_bdi_congested[sync]) == 0 ||
> > - !zone_is_reclaim_congested(zone)) {
> > + test_bit(ZONE_CONGESTED, &zone->flags)) {
> > cond_resched();
> >
> > /* In case we scheduled, work out time remaining */
>
> That's not equivalent.
>
> [snip]
>
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index 2836b5373b2e..590a92bec6a4 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -920,7 +920,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> > /* Case 1 above */
> > if (current_is_kswapd() &&
> > PageReclaim(page) &&
> > - zone_is_reclaim_writeback(zone)) {
> > + test_bit(ZONE_WRITEBACK, &zone->flags)) {
> > nr_immediate++;
> > goto keep_locked;
> >
> > @@ -1002,7 +1002,7 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> > */
> > if (page_is_file_cache(page) &&
> > (!current_is_kswapd() ||
> > - !zone_is_reclaim_dirty(zone))) {
> > + test_bit(ZONE_DIRTY, &zone->flags))) {
> > /*
> > * Immediately reclaim when written back.
> > * Similar in principal to deactivate_page()
>
> Nor is this.
>
> After fixed, for the oom killer bits:
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> since this un-obscurification is most welcome.
Yikes, thanks for catching those and acking. Updated patch:
---
next prev parent reply other threads:[~2014-09-02 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 14:27 [patch] mm: clean up zone flags Johannes Weiner
2014-09-02 21:42 ` David Rientjes
2014-09-02 22:26 ` Johannes Weiner [this message]
2014-09-05 10:20 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902222653.GA20186@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).