From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers
Date: Tue, 9 Sep 2014 22:11:38 -0700 [thread overview]
Message-ID: <20140909221138.2587d864.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1409100702190.5523@pobox.suse.cz>
On Wed, 10 Sep 2014 07:05:40 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
> > > --- a/mm/slab.c
> > > +++ b/mm/slab.c
> > > @@ -3612,7 +3612,7 @@ void kfree(const void *objp)
> > >
> > > trace_kfree(_RET_IP_, objp);
> > >
> > > - if (unlikely(ZERO_OR_NULL_PTR(objp)))
> > > + if (unlikely(ZERO_OR_NULL_PTR(objp) || IS_ERR(objp)))
> > > return;
> >
> > kfree() is quite a hot path to which this will add overhead. And we
> > have (as far as we know) no code which will actually use this at
> > present.
>
> We obviously don't, as such code will be causing explosions. This is meant
> as a prevention of problems such as the one that has just been fixed in
> ext4.
Well. I bet there exist sites which can pass an ERR_PTR to kfree but
haven't been know to do so yet because errors are rare. Your patch
would fix all those by magic, but is it worth the overhead?
This is the sort of error which a static checker could find. I wonder
if any of them do so.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-10 5:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:25 [PATCH] mm/sl[aou]b: make kfree() aware of error pointers Jiri Kosina
2014-09-09 23:21 ` Andrew Morton
2014-09-10 5:05 ` Jiri Kosina
2014-09-10 5:11 ` Andrew Morton [this message]
2014-09-10 6:36 ` Dan Carpenter
2014-09-10 13:56 ` Theodore Ts'o
2014-09-10 14:27 ` Dave Jones
2014-09-10 14:07 ` Theodore Ts'o
2014-09-10 14:24 ` Jiri Kosina
2014-09-10 14:33 ` Andrey Ryabinin
2014-09-10 14:42 ` Jiri Kosina
2014-09-10 15:43 ` Christoph Lameter
2014-09-10 14:26 ` Jiri Kosina
2014-09-10 15:21 ` Dan Carpenter
2014-09-10 15:28 ` Jiri Kosina
2014-09-10 15:53 ` Dan Carpenter
2014-09-10 19:40 ` Theodore Ts'o
2014-09-11 14:14 ` Rasmus Villemoes
2014-09-10 14:22 ` Christoph Lameter
2014-09-10 5:15 ` Valdis.Kletnieks
2014-09-10 6:51 ` Dan Carpenter
2014-09-10 13:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909221138.2587d864.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dan.carpenter@oracle.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).