From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Wang, Yalin" <Yalin.Wang@sonymobile.com>,
Jiang Liu <jiang.liu@huawei.com>
Cc: 'Will Deacon' <will.deacon@arm.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>,
"'linux-mm@kvack.org'" <linux-mm@kvack.org>
Subject: Re: [RFC Resend] arm:extend __init_end to a page align address
Date: Mon, 15 Sep 2014 11:55:25 +0100 [thread overview]
Message-ID: <20140915105525.GC12361@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D103D6DB491607@CNBJMBX05.corpusers.net>
On Mon, Sep 15, 2014 at 06:26:43PM +0800, Wang, Yalin wrote:
> this patch change the __init_end address to a page align address, so that free_initmem()
> can free the whole .init section, because if the end address is not page aligned,
> it will round down to a page align address, then the tail unligned page will not be freed.
Please wrap commit messages at or before column 72 - this makes "git log"
much easier to read once the change has been committed.
I have no objection to the arch/arm part of this patch. However, since
different people deal with arch/arm and arch/arm64, this patch needs to
be split.
Also, it may be worth patching include/asm-generic/vmlinux.lds.h to
indicate that __initrd_end should be page aligned - this seems to be a
requirement by the (new-ish) free_reserved_area() function, otherwise
it does indeed round down.
(Added Jiang Liu as the person responsible for free_reserved_area() for
any further comments.)
>
> Signed-off-by: Yalin wang <yalin.wang@sonymobile.com>
> ---
> arch/arm/kernel/vmlinux.lds.S | 2 +-
> arch/arm64/kernel/vmlinux.lds.S | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/vmlinux.lds.S b/arch/arm/kernel/vmlinux.lds.S index 6f57cb9..8e95aa4 100644
> --- a/arch/arm/kernel/vmlinux.lds.S
> +++ b/arch/arm/kernel/vmlinux.lds.S
> @@ -219,8 +219,8 @@ SECTIONS
> __data_loc = ALIGN(4); /* location in binary */
> . = PAGE_OFFSET + TEXT_OFFSET;
> #else
> - __init_end = .;
> . = ALIGN(THREAD_SIZE);
> + __init_end = .;
> __data_loc = .;
> #endif
>
> diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S index 97f0c04..edf8715 100644
> --- a/arch/arm64/kernel/vmlinux.lds.S
> +++ b/arch/arm64/kernel/vmlinux.lds.S
> @@ -97,9 +97,9 @@ SECTIONS
>
> PERCPU_SECTION(64)
>
> + . = ALIGN(PAGE_SIZE);
> __init_end = .;
>
> - . = ALIGN(PAGE_SIZE);
> _data = .;
> _sdata = .;
> RW_DATA_SECTION(64, PAGE_SIZE, THREAD_SIZE)
> --
> 1.9.2.msysgit.0
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-15 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:05 [PATCH] arm:free_initrd_mem should also free the memblock Wang, Yalin
2014-09-15 2:29 ` [PATCH] arm:extend __init_end to a page align address Wang, Yalin
2014-09-15 10:26 ` [RFC Resend] " Wang, Yalin
2014-09-15 10:55 ` Russell King - ARM Linux [this message]
2014-09-15 13:15 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915105525.GC12361@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Yalin.Wang@sonymobile.com \
--cc=jiang.liu@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).