From: Pavel Machek <pavel@ucw.cz>
To: kbuild test robot <fengguang.wu@intel.com>,
kernel list <linux-kernel@vger.kernel.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@01.org, pavel@ucw.cz, rtc-linux@googlegroups.com,
dan.carpenter@oracle.com
Subject: [patch] drivers/rtc/rtc-bq32k.c fix warnings I introduced
Date: Tue, 23 Sep 2014 21:40:21 +0200 [thread overview]
Message-ID: <20140923194021.GA15840@amd> (raw)
In-Reply-To: <542131f8.FeDGKH/9671AZbCt%fengguang.wu@intel.com>
Sorry about that, I somehow failed to notice rather severe warnings.
Signed-off-by: Pavel Machek <pavel@denx.de>
diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
index 4c24fb0..c02e246 100644
--- a/drivers/rtc/rtc-bq32k.c
+++ b/drivers/rtc/rtc-bq32k.c
@@ -132,9 +132,7 @@ static const struct rtc_class_ops bq32k_rtc_ops = {
static int trickle_charger_of_init(struct device *dev, struct device_node *node)
{
- int plen = 0;
- const uint32_t *setup;
- const uint32_t *reg;
+ unsigned char reg;
int error;
u32 ohms = 0;
@@ -166,7 +164,7 @@ static int trickle_charger_of_init(struct device *dev, struct device_node *node)
break;
default:
- dev_err(dev, "invalid resistor value (%d)\n", *setup);
+ dev_err(dev, "invalid resistor value (%d)\n", ohms);
return -EINVAL;
}
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-23 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 8:40 [next:master 7267/7446] drivers/rtc/rtc-bq32k.c:169:3: warning: 'setup' may be used uninitialized in this function kbuild test robot
2014-09-23 19:40 ` Pavel Machek [this message]
2014-09-23 21:01 ` Andrew Morton
2014-09-24 16:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923194021.GA15840@amd \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).