From: Ingo Molnar <mingo@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Layton <jeff.layton@primarydata.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/5 - resend] SCHED: add some "wait..on_bit...timeout()" interfaces.
Date: Thu, 25 Sep 2014 07:01:03 +0200 [thread overview]
Message-ID: <20140925050103.GB20431@gmail.com> (raw)
In-Reply-To: <20140925135519.3ae1fa60@notabene.brown>
* NeilBrown <neilb@suse.de> wrote:
>
> In commit c1221321b7c25b53204447cff9949a6d5a7ddddc
> sched: Allow wait_on_bit_action() functions to support a timeout
>
> I suggested that a "wait_on_bit_timeout()" interface would not meet my
> need. This isn't true - I was just over-engineering.
>
> Including a 'private' field in wait_bit_key instead of a focused
> "timeout" field was just premature generalization. If some other
> use is ever found, it can be generalized or added later.
>
> So this patch renames "private" to "timeout" with a meaning "stop
> waiting when "jiffies" reaches or passes "timeout",
> and adds two of the many possible wait..bit..timeout() interfaces:
>
> wait_on_page_bit_killable_timeout(), which is the one I want to use,
> and out_of_line_wait_on_bit_timeout() which is a reasonably general
> example. Others can be added as needed.
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> ---
> This time with EXPORT_SYMBOL_GPL.
Looks good to me, thanks!
Acked-by: Ingo Molnar <mingo@kernel.org>
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-25 5:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 1:28 [PATCH 0/5] Remove possible deadlocks in nfs_release_page() - V3 NeilBrown
2014-09-24 1:28 ` [PATCH 5/5] NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page() NeilBrown
2014-09-24 1:28 ` [PATCH 1/5] SCHED: add some "wait..on_bit...timeout()" interfaces NeilBrown
2014-09-24 7:04 ` Ingo Molnar
2014-09-25 3:23 ` NeilBrown
2014-09-25 3:28 ` Trond Myklebust
2014-09-25 3:55 ` [PATCH 1/5 - resend] " NeilBrown
2014-09-25 5:01 ` Ingo Molnar [this message]
2014-09-24 1:28 ` [PATCH 2/5] MM: export page_wakeup functions NeilBrown
2014-09-24 1:28 ` [PATCH 3/5] NFS: avoid deadlocks with loop-back mounted NFS filesystems NeilBrown
2014-09-24 1:28 ` [PATCH 4/5] NFS: avoid waiting at all in nfs_release_page when congested NeilBrown
2014-09-24 2:06 ` [PATCH 0/5] Remove possible deadlocks in nfs_release_page() - V3 Trond Myklebust
2014-09-24 11:27 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925050103.GB20431@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).