From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Feiner <pfeiner@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@parallels.com>,
Jamie Liu <jamieliu@google.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm: softdirty: keep bit when zapping file pte
Date: Thu, 25 Sep 2014 10:30:06 +0400 [thread overview]
Message-ID: <20140925063006.GN2227@moon> (raw)
In-Reply-To: <20140924145927.04e8eb7ba6c1410a797293c7@linux-foundation.org>
On Wed, Sep 24, 2014 at 02:59:27PM -0700, Andrew Morton wrote:
> On Sat, 20 Sep 2014 01:03:07 -0700 Peter Feiner <pfeiner@google.com> wrote:
>
> > Fixes the same bug as b43790eedd31e9535b89bbfa45793919e9504c34 and
> > 9aed8614af5a05cdaa32a0b78b0f1a424754a958 where the return value of
> > pte_*mksoft_dirty was being ignored.
> >
> > To be sure that no other pte/pmd "mk" function return values were
> > being ignored, I annotated the functions in
> > arch/x86/include/asm/pgtable.h with __must_check and rebuilt.
> >
>
> Grumble.
>
> It is useful to identify preceding similar patches but that isn't a
> good way of describing *this* patch. What is wrong with the current
> code, how does the patch fix it.
The userspace effect is that without this patch softdirty mark might be lost
if file mapped pte get zapped. It should go into @stable series after 3.12.
>
> And, particularly, what do you think are the end-user visible effects
> of the bug? This info helps people to work out which kernel versions
> need the fix.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-09-25 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 8:03 [PATCH] mm: softdirty: keep bit when zapping file pte Peter Feiner
2014-09-20 8:08 ` Cyrill Gorcunov
2014-09-24 21:59 ` Andrew Morton
2014-09-24 22:45 ` Peter Feiner
2014-09-25 6:30 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925063006.GN2227@moon \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jamieliu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pfeiner@google.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).