From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, peterz@infradead.org, mingo@kernel.org
Subject: Re: [PATCH 1/8] mm: replace remap_file_pages() syscall with emulation
Date: Wed, 8 Oct 2014 13:03:14 +0300 [thread overview]
Message-ID: <20141008100314.GA1795@node.dhcp.inet.fi> (raw)
In-Reply-To: <5434DEBD.8040607@synopsys.com>
On Wed, Oct 08, 2014 at 12:20:37PM +0530, Vineet Gupta wrote:
> Hi Kirill,
>
> Due to broken PAGE_FILE on arc, I was giving this emulation patch a try and it
> seems we need a minor fix to this patch. I know this is not slated for merge soon,
> but u can add the fix nevertheless and my Tested-by:
>
> Problem showed up with Ingo Korb's remap-demo.c test case from [1]
>
> [1] https://lkml.org/lkml/2014/7/14/335
>
> > +
> > + ret = do_mmap_pgoff(vma->vm_file, start, size,
> > + prot, flags, pgoff, &populate);
> > + if (populate)
> > + mm_populate(ret, populate);
> > +out:
> > + up_write(&mm->mmap_sem);
>
> On success needs to return 0, not mapped addr.
>
> if (!IS_ERR_VALUE(ret))
> ret = 0;
This bug (and few more) has been fixed long ago in -mm tree.
Thanks for testing, anyway.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-08 10:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 14:37 [RFC, PATCH 0/8] remap_file_pages() decommission Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 1/8] mm: replace remap_file_pages() syscall with emulation Kirill A. Shutemov
2014-10-08 6:50 ` Vineet Gupta
2014-10-08 10:03 ` Kirill A. Shutemov [this message]
2014-05-06 14:37 ` [PATCH 2/8] mm: kill vm_operations_struct->remap_pages Kirill A. Shutemov
2014-05-19 15:03 ` Christoph Hellwig
2014-05-19 15:14 ` Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 3/8] mm: kill zap_details->nonlinear_vma Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 4/8] mm, rmap: kill rmap_walk_control->file_nonlinear() Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 5/8] mm, rmap: kill vma->shared.nonlinear Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 6/8] mm, rmap: kill mapping->i_mmap_nonlinear Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 7/8] mm: kill VM_NONLINEAR and FAULT_FLAG_NONLINEAR Kirill A. Shutemov
2014-05-06 14:37 ` [PATCH 8/8] mm, x86: kill pte_to_pgoff(), pgoff_to_pte() and pte_file*() Kirill A. Shutemov
2014-05-06 21:35 ` [RFC, PATCH 0/8] remap_file_pages() decommission Andrew Morton
2014-05-06 21:51 ` Linus Torvalds
2014-05-06 23:03 ` Kirill A. Shutemov
2014-05-06 23:28 ` Andrew Morton
2014-05-07 9:12 ` Peter Zijlstra
2014-05-07 16:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008100314.GA1795@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=Vineet.Gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).