From: Fengwei Yin <yfw.kernel@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, fengguang.wu@intel.com,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page
Date: Sat, 11 Oct 2014 18:11:02 +0800 [thread overview]
Message-ID: <20141011101020.GA26953@gmail.com> (raw)
In-Reply-To: <5437EEA3.50705@intel.com>
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote:
> On 10/10/2014 06:21 AM, Fengwei Yin wrote:
> > @@ -787,6 +788,9 @@ check_pfn:
> > return NULL;
> > }
> >
> > + if (is_huge_zero_pfn(pfn))
> > + return NULL;
> > +
>
> That looks a lot better. One thing, why not put the is_huge_zero_pfn()
> check next to the is_zero_pfn() check?
On the arch which has PTE_SPECIAL feaure, we need to make sure the
is_huge_zero_pfn() is called after the pfn is checked if !pte_special().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-10-11 2:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 9:19 [PATCH] smaps should deal with huge zero page exactly same as normal zero page Fengwei Yin
2014-10-09 16:36 ` Dave Hansen
2014-10-10 9:33 ` Fengwei Yin
2014-10-10 13:21 ` Fengwei Yin
2014-10-10 14:35 ` Dave Hansen
2014-10-11 10:11 ` Fengwei Yin [this message]
2014-10-17 10:46 ` Fengwei Yin
2014-10-14 11:57 ` Kirill A. Shutemov
2014-10-15 10:30 ` Fengwei Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141011101020.GA26953@gmail.com \
--to=yfw.kernel@gmail.com \
--cc=dave.hansen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).