From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by kanga.kvack.org (Postfix) with ESMTP id A0B616B006E for ; Wed, 15 Oct 2014 05:13:52 -0400 (EDT) Received: by mail-wi0-f182.google.com with SMTP id n3so1258120wiv.15 for ; Wed, 15 Oct 2014 02:13:52 -0700 (PDT) Received: from kirsi1.inet.fi (mta-out1.inet.fi. [62.71.2.226]) by mx.google.com with ESMTP id fr3si5429951wib.4.2014.10.15.02.13.50 for ; Wed, 15 Oct 2014 02:13:51 -0700 (PDT) Date: Wed, 15 Oct 2014 12:13:41 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 1/2] mm: free compound page with correct order Message-ID: <20141015091341.GB12538@node.dhcp.inet.fi> References: <1413317800-25450-1-git-send-email-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413317800-25450-1-git-send-email-yuzhao@google.com> Sender: owner-linux-mm@kvack.org List-ID: To: Yu Zhao Cc: Andrew Morton , "Kirill A. Shutemov" , Mel Gorman , Rik van Riel , Ingo Molnar , Hugh Dickins , Sasha Levin , Bob Liu , Johannes Weiner , David Rientjes , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, Oct 14, 2014 at 01:16:39PM -0700, Yu Zhao wrote: > Compound page should be freed by put_page() or free_pages() with > correct order. Not doing so with causing the tail pages leaked. > > The compound order can be obtained by compound_order() or use > HPAGE_PMD_ORDER in our case. Some people would argue the latter > is faster but I prefer the former which is more general. > > Signed-off-by: Yu Zhao Urghh.. Sorry about that. Acked-by: Kirill A. Shutemov Fixes: 97ae17497e99 ("thp: implement refcounting for huge zero page") Cc: stable@vger.kernel.org # v3.8+ -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org