From: Alex Thorlton <athorlton@sgi.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alex Thorlton <athorlton@sgi.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Bob Liu <lliubbo@gmail.com>, David Rientjes <rientjes@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Kees Cook <keescook@chromium.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>, Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vladimir Davydov <vdavydov@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Convert khugepaged to a task_work function
Date: Thu, 30 Oct 2014 13:25:42 -0500 [thread overview]
Message-ID: <20141030182542.GB2984@sgi.com> (raw)
In-Reply-To: <20141030083544.GX12538@two.firstfloor.org>
On Thu, Oct 30, 2014 at 09:35:44AM +0100, Andi Kleen wrote:
> We already have too many VM tunables. Better would be to switch
> automatically somehow.
>
> I guess you could use some kind of work stealing scheduler, but these
> are fairly complicated. Maybe some simpler heuristics can be found.
That would be a better option in general, but (admittedly not having
thought about it much), I can't think of a good way to determine when to
make that switch. The main problem being that we're not really seeing a
negative performance impact from khugepaged, but some undesired
behavior, which always exists.
Perhaps we could make a decision based on the number of remote
allocations made by khugepaged? If we see a lot of allocations to
distant nodes, then maybe we tell khugepaged to stop running scans for a
particular process/mm and let the job handle things itself, either using
the task_work style scan that I've proposed, or just banning khugepaged,
period. Again, I don't think this is a very good way to make the
decision, but something to think about.
> BTW my thinking has been usually to actually use more khugepageds to
> scan large address spaces faster.
I hadn't thought of it, but I suppose that is an option as well. Unless
I've completely missed something in the code, I don't think there's a
way to do this now, right? Either way, I suppose it wouldn't be too hard
to do, but this still leaves the window wide open for allocations to be
made far away from where the process really needs them. Maybe if we had
a way to spin up a new khugepaged on the fly, so that users can pin it
where they want it, that would work? Just brainstorming here...
- Alex
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-10-30 18:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 2:49 [PATCH 0/4] Convert khugepaged to a task_work function Alex Thorlton
2014-10-23 2:49 ` [PATCH 1/4] Disable khugepaged thread Alex Thorlton
2014-10-23 2:49 ` [PATCH] Add pgcollapse controls to task_struct Alex Thorlton
2014-10-23 15:29 ` Alex Thorlton
2014-10-23 2:49 ` [PATCH 3/4] Convert khugepaged scan functions to work with task_work Alex Thorlton
2014-10-23 2:49 ` [PATCH 4/4] Add /proc files to expose per-mm pgcollapse stats Alex Thorlton
2014-10-23 3:06 ` [PATCH 1/2] Add pgcollapse stat counter to task_struct Alex Thorlton
2014-10-23 3:06 ` [PATCH 2/2] Add /proc files to expose per-mm pgcollapse stats Alex Thorlton
2014-10-23 17:55 ` [PATCH 0/4] Convert khugepaged to a task_work function Rik van Riel
2014-10-23 18:05 ` Alex Thorlton
2014-10-23 18:52 ` Alex Thorlton
2014-10-28 12:12 ` Andi Kleen
2014-10-28 12:58 ` Rik van Riel
2014-10-28 15:39 ` Rik van Riel
2014-10-31 20:27 ` Vlastimil Babka
2014-11-17 21:34 ` Alex Thorlton
2014-11-10 11:03 ` Mel Gorman
2014-11-17 21:16 ` Alex Thorlton
2014-10-29 21:58 ` Alex Thorlton
2014-10-30 0:23 ` Kirill A. Shutemov
2014-10-30 8:35 ` Andi Kleen
2014-10-30 18:25 ` Alex Thorlton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030182542.GB2984@sgi.com \
--to=athorlton@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).