From: Michal Hocko <mhocko@suse.cz>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 143/283] mm/slab.c:3260:4: error: implicit declaration of function 'slab_free'
Date: Thu, 6 Nov 2014 15:05:15 +0100 [thread overview]
Message-ID: <20141106140514.GG7202@dhcp22.suse.cz> (raw)
In-Reply-To: <20141106092849.GC4839@esperanza>
[Dropping kbuild-test from CC]
On Thu 06-11-14 12:28:49, Vladimir Davydov wrote:
> Hi Michal,
>
> On Thu, Nov 06, 2014 at 10:08:45AM +0100, Michal Hocko wrote:
> > I have encountered the same error as well. We need to move the forward
> > declaration up outside of CONFIG_NUMA:
>
> Yes, that's my fault, I'm sorry. Thank you for fixing this.
NP.
> BTW what do you think about the whole patch set that introduced it -
> https://lkml.org/lkml/2014/11/3/781 - w/o diving deeply into details,
> just by looking at the general idea described in the cover letter?
The series is still stuck in my inbox and I plan to review your shrinker
code first. I hope to get to it ASAP but not sooner than Monday as I
will be off until Sunday.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-06 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 1:16 [mmotm:master 143/283] mm/slab.c:3260:4: error: implicit declaration of function 'slab_free' kbuild test robot
2014-11-06 9:08 ` Michal Hocko
2014-11-06 9:28 ` Vladimir Davydov
2014-11-06 14:05 ` Michal Hocko [this message]
2014-11-06 14:30 ` Vladimir Davydov
2014-11-06 14:33 ` Michal Hocko
2014-11-06 9:13 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106140514.GG7202@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).