From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id 933186B0069 for ; Tue, 18 Nov 2014 10:42:53 -0500 (EST) Received: by mail-wg0-f54.google.com with SMTP id y10so6616788wgg.27 for ; Tue, 18 Nov 2014 07:42:52 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id t19si21746433wiv.66.2014.11.18.07.42.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Nov 2014 07:42:52 -0800 (PST) Date: Tue, 18 Nov 2014 15:42:46 +0000 From: Mel Gorman Subject: Re: [RFC PATCH 0/7] Replace _PAGE_NUMA with PAGE_NONE protections Message-ID: <20141118154246.GB2725@suse.de> References: <1415971986-16143-1-git-send-email-mgorman@suse.de> <5466C8A5.3000402@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5466C8A5.3000402@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: To: Sasha Levin Cc: Linux Kernel , Linux-MM , Aneesh Kumar , Hugh Dickins , Dave Jones , Rik van Riel , Ingo Molnar , Kirill Shutemov , Linus Torvalds On Fri, Nov 14, 2014 at 10:29:41PM -0500, Sasha Levin wrote: > On 11/14/2014 08:32 AM, Mel Gorman wrote:> This is follow up from the "pipe/page fault oddness" thread. > > Hi Mel, > > Applying this patch series I've started seeing the following straight away: > > [ 367.547848] page:ffffea0003fb7db0 count:1007 mapcount:1005 mapping:ffff8800691f2f58 index:0x37 > [ 367.551481] flags: 0x5001aa8030202d(locked|referenced|uptodate|lru|writeback|unevictable|mlocked) > [ 367.555382] page dumped because: VM_BUG_ON_PAGE(!v9inode->writeback_fid) > [ 367.558262] page->mem_cgroup:ffff88006d8a1bd8 > [ 367.560403] ------------[ cut here ]------------ > [ 367.562343] kernel BUG at fs/9p/vfs_addr.c:190! > [ 367.564239] invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN > [ 367.566991] Dumping ftrace buffer: > [ 367.568481] (ftrace buffer empty) > [ 367.569914] Modules linked in: > [ 367.570254] CPU: 3 PID: 8234 Comm: kworker/u52:1 Not tainted 3.18.0-rc4-next-20141114-sasha-00054-ga9ff95e-dirty #1459 Thanks Sasha. I don't see a next-20141114 so I looked at next-20141113 and assuming they are similar. It does not appear that writeback_fid is a struct page so it's not clear what VM_BUG_ON_PAGE means in this context. Certainly the fields look screwy but I think it's just accessing garbage. I tried reproducing this but my KVM setup appears to be broken after an update and not even able to boot 3.17 properly let alone with the patches. I still have a few questions though. 1. I'm assuming this is a KVM setup but can you confirm? 2. Are you using numa=fake=N? 3. If you are using fake NUMA, what happens if you boot without it as that should make the patches a no-op? 4. Similarly, does the kernel boot properly without without patches? 5. Are any other patches applied because the line numbers are not lining up exactly? 6. As my own KVM setup appears broken, can you tell me if the host kernel has changed recently? If so, does using an older host kernel make a difference? At the moment I'm scratching my head trying to figure out how the patches could break 9p like this as I don't believe KVM is doing any tricks with the same bits that could result in loss. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org