Re: [mmotm:master 210/397] mm/zsmalloc.c:1021:11: error: 'ZS_SIZE_CLASSES' undeclared

Minchan Kim
2014-12-01T00:26:46Z

Hello,

On Thu, Nov 27, 2014 at 10:12:49PM +0800, Ganesh Mahendran wrote:
> Hello:
>
> I know why the build failed.
>
> I sent patch 1 [mm/zsmalloc: avoid duplicate assignment of prev_class]
> firstly. It was accept.
> And then I sent patch 2 [mm/zsmalloc: support allocating obj with size
> of ZS_MAX_ALLOC_SIZE]. I was accept.
>
> But Dan Streetman <ddstreet@ieee.org> found an issue in patch 1
> [mm/zsmalloc: avoid duplicate assignment of prev_class].
> Then the first patch 1 was dropped. But the second patch was *based*
> on the first patch. So the build is failed on:
> commit: 304e521b912aa95514a5b66f7d6795d096f15535 [210/397]
> mm/zsmalloc: support allocating obj with size of ZS_MAX_ALLOC_SIZE
> which was based on patch 1.
>
> But it is ok after the patch [mm/zsmalloc: avoid duplicate assignment
> of prev_class].
>
> So what should I do now?

Normally, Andrew Morton is one of kind maintainers who fixes such
trivial problem by themselves but it doesn't mean we should wait
on him so what we can do is just make a fix and describe the problem
and send it to him. Other than that, he will handle.

Thanks.

-
Kind regards,
Minchan Kim