From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by kanga.kvack.org (Postfix) with ESMTP id C759C6B0038 for ; Fri, 2 Jan 2015 00:11:14 -0500 (EST) Received: by mail-wi0-f171.google.com with SMTP id bs8so27270871wib.10 for ; Thu, 01 Jan 2015 21:11:14 -0800 (PST) Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz. [195.113.26.193]) by mx.google.com with ESMTP id m1si41651716wje.153.2015.01.01.21.11.12 for ; Thu, 01 Jan 2015 21:11:12 -0800 (PST) Date: Fri, 2 Jan 2015 06:11:11 +0100 From: Pavel Machek Subject: Re: [PATCH 0/3] mm: cma: /proc/cmainfo Message-ID: <20150102051111.GC4873@amd> References: <20141229023639.GC27095@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141229023639.GC27095@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: "Stefan I. Strogin" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Andrew Morton , Marek Szyprowski , Michal Nazarewicz , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Dmitry Safonov , Pintu Kumar , Weijie Yang , Laura Abbott , SeongJae Park , Hui Zhu , Dyasly Sergey , Vyacheslav Tyrtov On Mon 2014-12-29 11:36:39, Minchan Kim wrote: > Hello, > > On Fri, Dec 26, 2014 at 05:39:01PM +0300, Stefan I. Strogin wrote: > > Hello all, > > > > Here is a patch set that adds /proc/cmainfo. > > > > When compiled with CONFIG_CMA_DEBUG /proc/cmainfo will contain information > > about about total, used, maximum free contiguous chunk and all currently > > allocated contiguous buffers in CMA regions. The information about allocated > > CMA buffers includes pid, comm, allocation latency and stacktrace at the > > moment of allocation. We should not add new non-process related files in /proc. So... NAK. Should this go to debugfs instead? > It just says what you are doing but you didn't say why we need it. > I can guess but clear description(ie, the problem what you want to > solve with this patchset) would help others to review, for instance, > why we need latency, why we need callstack, why we need new wheel > rather than ftrace and so on. > > Thanks. > > > > > Example: > > > > # cat /proc/cmainfo > > CMARegion stat: 65536 kB total, 248 kB used, 65216 kB max contiguous chunk -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org