From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
akpm@linux-foundation.org, aarcange@redhat.com,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc.c: drop dead destroy_compound_page()
Date: Tue, 6 Jan 2015 20:29:54 +0200 [thread overview]
Message-ID: <20150106182954.GA30484@node.dhcp.inet.fi> (raw)
In-Reply-To: <54AC1ED5.2050101@suse.cz>
On Tue, Jan 06, 2015 at 06:43:49PM +0100, Vlastimil Babka wrote:
> On 01/05/2015 12:46 PM, Kirill A. Shutemov wrote:
> > The only caller is __free_one_page(). By the time we should have
> > page->flags to be cleared already:
> >
> > - for 0-order pages though PCP list:
>
> Can there even be a 0-order compound page? I guess not, so this is just confusing?
No, it can't.
Since I propose the VM_BUG_ON(page->flags), I tried to make point that
flags are cleared by the point in any case.
> Otherwise it seems like you are right and it's a dead code to be removed. I
> tried to check history to see when it was actually needed, but seems it predates
> git.
Yeah. But we keep updating it...
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-06 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 11:46 [PATCH] mm/page_alloc.c: drop dead destroy_compound_page() Kirill A. Shutemov
2015-01-06 17:43 ` Vlastimil Babka
2015-01-06 18:29 ` Kirill A. Shutemov [this message]
2015-01-07 21:40 ` Andrew Morton
2015-01-08 14:10 ` Kirill A. Shutemov
2015-01-10 0:24 ` Andrew Morton
2015-01-10 0:41 ` Kirill A. Shutemov
2015-01-10 1:06 ` Andrew Morton
2015-01-10 1:15 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106182954.GA30484@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).