From: Vladimir Davydov <vdavydov@parallels.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 3/3] slub: make dead caches discard free slabs immediately
Date: Tue, 27 Jan 2015 11:23:01 +0300 [thread overview]
Message-ID: <20150127082301.GD28978@esperanza> (raw)
In-Reply-To: <20150127080009.GB11358@js1304-P5Q-DELUXE>
Hi Joonsoo,
On Tue, Jan 27, 2015 at 05:00:09PM +0900, Joonsoo Kim wrote:
> On Mon, Jan 26, 2015 at 03:55:29PM +0300, Vladimir Davydov wrote:
> > @@ -3381,6 +3390,15 @@ void __kmem_cache_shrink(struct kmem_cache *s)
> > kmalloc(sizeof(struct list_head) * objects, GFP_KERNEL);
> > unsigned long flags;
> >
> > + if (deactivate) {
> > + /*
> > + * Disable empty slabs caching. Used to avoid pinning offline
> > + * memory cgroups by freeable kmem pages.
> > + */
> > + s->cpu_partial = 0;
> > + s->min_partial = 0;
> > + }
> > +
>
> Maybe, kick_all_cpus_sync() is needed here since object would
> be freed asynchronously so they can't see this updated value.
I thought flush_all() should do the trick, no?
Thanks,
Vladimir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-27 8:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 12:55 [PATCH -mm 0/3] slub: make dead caches discard free slabs immediately Vladimir Davydov
2015-01-26 12:55 ` [PATCH -mm 1/3] slub: don't fail kmem_cache_shrink if slab placement optimization fails Vladimir Davydov
2015-01-26 15:48 ` Christoph Lameter
2015-01-26 17:01 ` Vladimir Davydov
2015-01-26 18:24 ` Christoph Lameter
2015-01-26 19:36 ` Vladimir Davydov
2015-01-26 19:53 ` Christoph Lameter
2015-01-27 12:58 ` Vladimir Davydov
2015-01-27 17:02 ` Christoph Lameter
2015-01-28 15:00 ` Vladimir Davydov
2015-01-26 12:55 ` [PATCH -mm 2/3] slab: zap kmem_cache_shrink return value Vladimir Davydov
2015-01-26 15:49 ` Christoph Lameter
2015-01-26 17:04 ` Vladimir Davydov
2015-01-26 18:26 ` Christoph Lameter
2015-01-26 19:48 ` Vladimir Davydov
2015-01-26 19:55 ` Christoph Lameter
2015-01-26 20:16 ` Vladimir Davydov
2015-01-26 20:28 ` Christoph Lameter
2015-01-26 20:43 ` Vladimir Davydov
2015-01-26 12:55 ` [PATCH -mm 3/3] slub: make dead caches discard free slabs immediately Vladimir Davydov
2015-01-27 8:00 ` Joonsoo Kim
2015-01-27 8:23 ` Vladimir Davydov [this message]
2015-01-27 9:21 ` Joonsoo Kim
2015-01-27 9:28 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127082301.GD28978@esperanza \
--to=vdavydov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).